draft: locked down siteinfo#437
Draft
kyanha wants to merge 2 commits into
Draft
Conversation
kyanha
commented
Jul 3, 2026
kyanha
commented
- feat: Make siteinfo query work on private wikis
- feat: I can't push with any failing tests. Can you address them? Edits applied in response to user prompt.
Edits applied in response to user prompt.
Original prompt:
I can't push with any failing tests. Can you address them?
```
❯ tests/auth/paths.test.ts (4 tests | 1 failed) 21ms
✓ returns MCP_OAUTH_CREDENTIALS_FILE verbatim when set 4ms
✓ uses XDG_CONFIG_HOME on Linux/macOS when set 1ms
× falls back to ~/.config on Linux/macOS when XDG unset 11ms
✓ uses %APPDATA% on win32 1ms
❯ tests/transport/uploadGuard.test.ts (9 tests | 2 failed) 23ms
✓ rejects when allowedDirs is empty 7ms
✓ rejects a relative filepath 1ms
✓ rejects a non-existent filepath with a clear message 1ms
× accepts and returns the canonical path for a file inside an allowed dir 7ms
✓ rejects when a symlink resolves outside the allowlist 1ms
✓ rejects a `..` traversal whose realpath escapes the allowlist 1ms
✓ does not match a sibling directory with a similar prefix 0ms
✓ accepts when the resolved path equals the allowlist entry exactly 0ms
× accepts when the file is under any of several allowlist entries 1ms
```
The "falls back to ~/.config for Linux and MacOS" should be skipped on Windows, at the least.
```
kyanha
marked this pull request as draft
July 3, 2026 11:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.