Added middleware compatible with JWT#43
Open
BhagatHarsh wants to merge 4 commits intoProgramming-Club-Ahmedabad-University:mainfrom
Open
Added middleware compatible with JWT#43BhagatHarsh wants to merge 4 commits intoProgramming-Club-Ahmedabad-University:mainfrom
BhagatHarsh wants to merge 4 commits intoProgramming-Club-Ahmedabad-University:mainfrom
Conversation
Collaborator
|
Is there no environment variable method to this? The private key should ideally never be exposed |
Contributor
Author
|
If you want a .env file then i can definitely make one, the reason for me doing it the easy way is that the website is still in progress most of the URL's and sensitive information is open and just for testing. so when it is finished a new PRIV_KEY will be generated and then set as the environment variable. |
Collaborator
|
Agreed but then an additional pr will have to be made for the same How about make an env variable and additionally comment out the keys and keep |
Contributor
Author
|
@mirchandani-mohnish please review the changes. |
Contributor
Author
|
Please review the changes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added the middleware folder and the file auth.middleware.js containing the middleware used for auth in protected routes. checked the middleware by creating a test route.
Related Issue
This pull request is based on the issue #12.
Motivation and Context
The files changed:
server/middlewares/auth.middleware.js
contains the main logic of the middleware which extracts the Bearer token from the auth headers and verifys it using the JWT library. deals with erros as needed.
server/routes/auth.routes.js
Created a protected test route which if successfuly authenticates then sends the users information back as a JSON object.
generating a new token
request that was made using the token in the auth header
If token expires