Skip to content

Updates to Bandwidth Integration HOW-TO based on my experience#2205

Closed
rhayhow wants to merge 4 commits intoProgressiveCoders:mainfrom
rhayhow:main
Closed

Updates to Bandwidth Integration HOW-TO based on my experience#2205
rhayhow wants to merge 4 commits intoProgressiveCoders:mainfrom
rhayhow:main

Conversation

@rhayhow
Copy link
Copy Markdown

@rhayhow rhayhow commented Aug 8, 2022

Fixes # (issue)

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change, and any blockers that make your change a WIP

Checklist:

  • I have manually tested my changes on desktop and mobile
  • The test suite passes locally with my changes
  • If my change is a UI change, I have attached a screenshot to the description section of this pull request
  • My change is 300 lines of code or less, or has a documented reason in the description why it’s longer
  • I have made any necessary changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • My PR is labeled [WIP] if it is in progress

@rhayhow
Copy link
Copy Markdown
Author

rhayhow commented Aug 8, 2022

I have shared some of the details of this pull request with @Arique1104 so they should have a sense of what the changes are.

Copy link
Copy Markdown
Collaborator

@Arique1104 Arique1104 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's my only addition, to add on some documentation to our Service Managers page.

# Bandwidth Integration

Bandwidth.com is a telephone service API company. To use Bandwidth, set `DEFAULT_SERVICE=bandwidth`. The `sticky-sender` and `num-picker` service managers are required for the Bandwidth extension to work. `sticky-sender` must come before `numpicker-basic` in the `SERVICE_MANAGERS` environment variable.
Bandwidth.com is a telephone service API company. To use Bandwidth, set `DEFAULT_SERVICE=bandwidth`. The `sticky-sender` and `numpicker-basic` service managers are required for the Bandwidth extension to work. `sticky-sender` must come before `numpicker-basic` in the `SERVICE_MANAGERS` environment variable. NOTE: Because service managers are complicated, there is not an entry for SERVICE_MANAGERS in the Spoke Documentation Hub. Just add it as an enviromental variable.
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's the documentation for Service Managers

We could have the Service Managers doc (linked above) can have a new section for ngpvan and beneath it, link the HOWTO Integrate Bandwidth. I'd be happy to make those changes and push them to this branch. :)

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will look at what is required to update the Service Managers doc. Please feel free to close the request :)

@Arique1104
Copy link
Copy Markdown
Collaborator

@rhayhow, thank you for these changes! You should see them reflected in the Bandwidth Community Input Pull Request

I'd love it if you could review those changes and give any feedback.

I had a lot of trouble getting your branch pulled to my local, so I ended up incorporating your edits and making a couple of markdown readability edits and I hope the final product is useful.

With your permission, I'd like to close this pull request.

@rhayhow
Copy link
Copy Markdown
Author

rhayhow commented Aug 9, 2022

Please feel free to close the pull request.

@rhayhow rhayhow closed this Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants