Kodiak: Add initial support for Galaxy Tab S7 FE#747
Draft
qaz6750 wants to merge 1 commit intoProject-Aloha:mainfrom
Draft
Kodiak: Add initial support for Galaxy Tab S7 FE#747qaz6750 wants to merge 1 commit intoProject-Aloha:mainfrom
qaz6750 wants to merge 1 commit intoProject-Aloha:mainfrom
Conversation
Signed-off-by: XiaoYeZi <[email protected]>
There was a problem hiding this comment.
Pull request overview
Adds initial device package/binaries for the Samsung Galaxy Tab S7 FE (WiFi) under KodiakPkg, including partitioning and panel configuration assets needed for early boot/UEFI bring-up.
Changes:
- Added RPMB/GPT partition configuration (
SecParti.cfg) and a platform BDS menu configuration (BDS_Menu.cfg). - Added multiple panel configuration XMLs for different panels/modes (DSI cmd/vid, DSC, dual DSI, various resolutions/refresh rates).
- Added autogenerated UEFI module manifests (
*.inf) and dependency expressions (*.depex), plus DXE/APRIORI include lists for the platform binary set.
Reviewed changes
Copilot reviewed 189 out of 326 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/RawFiles/SecParti.cfg | Adds RPMB/GPT partition layout config for the device. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/RawFiles/Panel_truly_wqxga_dual_vid.xml | Adds Truly WQXGA dual-DSI video-mode panel definition. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/RawFiles/Panel_truly_wqxga_dual_cmd.xml | Adds Truly WQXGA dual-DSI command-mode panel definition. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/RawFiles/Panel_truly_wqxga_dsc_vid.xml | Adds Truly WQXGA single-DSI DSC video-mode panel definition. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/RawFiles/Panel_truly_wqxga_dsc_cmd.xml | Adds Truly WQXGA single-DSI DSC command-mode panel definition. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/RawFiles/Panel_truly_1080p_vid.xml | Adds Truly FHD video-mode panel definition. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/RawFiles/Panel_truly_1080p_cmd.xml | Adds Truly FHD command-mode panel definition. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/RawFiles/Panel_sharp_4k_dsc_vid.xml | Adds Sharp 4K dual-DSI DSC video-mode panel definition. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/RawFiles/Panel_sharp_4k_dsc_cmd.xml | Adds Sharp 4K dual-DSI DSC command-mode panel definition. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/RawFiles/Panel_sharp_1080p_cmd.xml | Adds Sharp 1080p command-mode panel definition. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/RawFiles/Panel_r66451_144hz_fhd_plus_dsc_cmd_cphy.xml | Adds Visionox R66451 144Hz DSC cmd-mode panel definition (C-PHY). |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/RawFiles/Panel_r66451_120hz_fhd_plus_dsc_cmd_cphy.xml | Adds Visionox R66451 120Hz DSC cmd-mode panel definition (C-PHY). |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/RawFiles/Panel_nt36860_wqhd_dsc_vid.xml | Adds NT36860 WQHD DSC video-mode panel definition (C-PHY). |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/RawFiles/Panel_boe_amoled_wqhd_dsc_vid.xml | Adds BOE WQHD AMOLED DSC video-mode panel definition. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/RawFiles/Panel_boe_amoled_wqhd_dsc_cmd.xml | Adds BOE WQHD AMOLED DSC command-mode panel definition. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/RawFiles/Panel_boe_amoled_fhd_dsc_cmd.xml | Adds BOE FHD AMOLED DSC command-mode panel definition. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/RawFiles/BDS_Menu.cfg | Adds platform BDS menu entries for bring-up and utilities. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/XBLCore/XBLCore.inf | Autogenerated INF manifest for XBLCore binary. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/XhciPciEmulationDxe/XhciPciEmulationDxe.inf | Autogenerated INF manifest for XHCI PCI emulation DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/XhciDxe/XhciDxe.inf | Autogenerated INF manifest for XHCI DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/VerifiedBootDxe/VerifiedBootDxe.inf | Autogenerated INF manifest for VerifiedBoot DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/VerifiedBootDxe/VerifiedBootDxe.depex | Autogenerated DEPEX for VerifiedBoot DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/VcsDxe/VcsDxe.inf | Autogenerated INF manifest for VCS DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/VcsDxe/VcsDxe.depex | Autogenerated DEPEX for VCS DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/VariableDxe/VariableDxe.inf | Autogenerated INF manifest for Variable DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/VariableDxe/VariableDxe.depex | Autogenerated DEPEX for Variable DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/UsbfnDwc3Dxe/UsbfnDwc3Dxe.inf | Autogenerated INF manifest for USBFn DWC3 DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/UsbPwrCtrlDxe/UsbPwrCtrlDxe.inf | Autogenerated INF manifest for USB power control DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/UsbPwrCtrlDxe/UsbPwrCtrlDxe.depex | Autogenerated DEPEX for USB power control DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/UsbMsdDxe/UsbMsdDxe.inf | Autogenerated INF manifest for USB MSD DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/UsbMsdDxe/UsbMsdDxe.depex | Autogenerated DEPEX for USB MSD DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/UsbMassStorageDxe/UsbMassStorageDxe.inf | Autogenerated INF manifest for USB Mass Storage DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/UsbKbDxe/UsbKbDxe.inf | Autogenerated INF manifest for USB keyboard DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/UsbInitDxe/UsbInitDxe.inf | Autogenerated INF manifest for USB init DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/UsbInitDxe/UsbInitDxe.depex | Autogenerated DEPEX for USB init DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/UsbDeviceDxe/UsbDeviceDxe.inf | Autogenerated INF manifest for USB device DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/UsbDeviceDxe/UsbDeviceDxe.depex | Autogenerated DEPEX for USB device DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/UsbConfigDxe/UsbConfigDxe.inf | Autogenerated INF manifest for USB config DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/UsbConfigDxe/UsbConfigDxe.depex | Autogenerated DEPEX for USB config DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/UsbBusDxe/UsbBusDxe.inf | Autogenerated INF manifest for USB bus DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/ULogDxe/ULogDxe.inf | Autogenerated INF manifest for ULog DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/ULogDxe/ULogDxe.depex | Autogenerated DEPEX for ULog DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/UFSDxe/UFSDxe.inf | Autogenerated INF manifest for UFS DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/UFSDxe/UFSDxe.depex | Autogenerated DEPEX for UFS DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/UCDxe/UCDxe.inf | Autogenerated INF manifest for UCDxe. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/TzDxe/TzDxeLA.inf | Autogenerated INF manifest for TZ DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/TzDxe/ScmDxeLA.inf | Autogenerated INF manifest for SCM DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/TsensDxe/TsensDxe.inf | Autogenerated INF manifest for Tsens DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/TsensDxe/TsensDxe.depex | Autogenerated DEPEX for Tsens DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/TLMMDxe/TLMMDxe.inf | Autogenerated INF manifest for TLMM DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/TLMMDxe/TLMMDxe.depex | Autogenerated DEPEX for TLMM DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/SmemDxe/SmemDxe.inf | Autogenerated INF manifest for SMEM DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/SmemDxe/SmemDxe.depex | Autogenerated DEPEX for SMEM DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/SimpleTextInOutSerialDxe/SimpleTextInOutSerial.inf | Autogenerated INF manifest for serial text in/out DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/SimpleTextInOutSerialDxe/SimpleTextInOutSerial.depex | Autogenerated DEPEX for serial text in/out DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/ShmBridgeDxe/ShmBridgeDxeLA.inf | Autogenerated INF manifest for ShmBridge DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/ShmBridgeDxe/ShmBridgeDxeLA.depex | Autogenerated DEPEX for ShmBridge DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/SerialPortDxe/SerialPortDxe.inf | Autogenerated INF manifest for SerialPort DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/SerialPortDxe/SerialPortDxe.depex | Autogenerated DEPEX for SerialPort DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/SecRSADxe/SecRSADxe.inf | Autogenerated INF manifest for SecRSA DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/SdccDxe/SdccDxe.inf | Autogenerated INF manifest for SDCC DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/SamsungDxe/VibDxe/VibDxe.inf | Autogenerated INF manifest for Samsung Vib DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/SamsungDxe/VibDxe/VibDxe.depex | Autogenerated DEPEX for Samsung Vib DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/SamsungDxe/RedriverDxe/RedriverDxe.inf | Autogenerated INF manifest for Samsung Redriver DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/SamsungDxe/RedriverDxe/RedriverDxe.depex | Autogenerated DEPEX for Samsung Redriver DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/SamsungDxe/MuicDxe/MuicDxe.inf | Autogenerated INF manifest for Samsung MUIC DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/SamsungDxe/MuicDxe/MuicDxe.depex | Autogenerated DEPEX for Samsung MUIC DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/SamsungDxe/GuidedFvDxe/GuidedFvDxe.inf | Autogenerated INF manifest for Samsung GuidedFv DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/SamsungDxe/GuidedFvDxe/GuidedFvDxe.depex | Autogenerated DEPEX for Samsung GuidedFv DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/SamsungDxe/ChgDxe/ChgDxe.inf | Autogenerated INF manifest for Samsung charger DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/SamsungDxe/ChgDxe/ChgDxe.depex | Autogenerated DEPEX for Samsung charger DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/SamsungDxe/CcicDxe/CcicDxe.inf | Autogenerated INF manifest for Samsung CCIC DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/SamsungDxe/CcicDxe/CcicDxe.depex | Autogenerated DEPEX for Samsung CCIC DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/SamsungDxe/BoardInfoDxe/BoardInfoDxe.inf | Autogenerated INF manifest for Samsung BoardInfo DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/SamsungDxe/BoardInfoDxe/BoardInfoDxe.depex | Autogenerated DEPEX for Samsung BoardInfo DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/SPMIDxe/SPMIDxe.inf | Autogenerated INF manifest for SPMI DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/SPMIDxe/SPMIDxe.depex | Autogenerated DEPEX for SPMI DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/SPIDxe/SPIDxe.inf | Autogenerated INF manifest for SPI DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/RpmhDxe/RpmhDxe.inf | Autogenerated INF manifest for RPMh DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/RpmhDxe/RpmhDxe.depex | Autogenerated DEPEX for RPMh DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/ResetRuntimeDxe/ResetRuntimeDxe.inf | Autogenerated INF manifest for ResetRuntime DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/ResetRuntimeDxe/ResetRuntimeDxe.depex | Autogenerated DEPEX for ResetRuntime DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/RNGDxe/RngDxe.inf | Autogenerated INF manifest for RNG DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/QcomWDogDxe/QcomWDogDxe.inf | Autogenerated INF manifest for Qcom watchdog DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/QcomWDogDxe/QcomWDogDxe.depex | Autogenerated DEPEX for Qcom watchdog DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/QcomBds/QcomBds.inf | Autogenerated INF manifest for QcomBds DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/QcomBds/QcomBds.depex | Autogenerated DEPEX for QcomBds DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/PwrUtilsDxe/PwrUtilsDxe.inf | Autogenerated INF manifest for PwrUtils DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/PwrUtilsDxe/PwrUtilsDxe.depex | Autogenerated DEPEX for PwrUtils DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/PmicDxe/PmicDxeLa.inf | Autogenerated INF manifest for PMIC DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/PmicDxe/PmicDxeLa.depex | Autogenerated DEPEX for PMIC DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/PlatformInfoDxe/PlatformInfoDxe.inf | Autogenerated INF manifest for PlatformInfo DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/PlatformInfoDxe/PlatformInfoDxe.depex | Autogenerated DEPEX for PlatformInfo DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/ParserDxe/ParserDxe.inf | Autogenerated INF manifest for Parser DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/ParserDxe/ParserDxe.depex | Autogenerated DEPEX for Parser DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/PILProxyDxe/PILProxyDxe.inf | Autogenerated INF manifest for PILProxy DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/PILProxyDxe/PILProxyDxe.depex | Autogenerated DEPEX for PILProxy DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/PILDxe/PILDxe.inf | Autogenerated INF manifest for PIL DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/PILDxe/PILDxe.depex | Autogenerated DEPEX for PIL DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/NpaDxe/NpaDxe.inf | Autogenerated INF manifest for NPA DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/NpaDxe/NpaDxe.depex | Autogenerated DEPEX for NPA DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/MinidumpTADxe/MinidumpTADxe.inf | Autogenerated INF manifest for MinidumpTA DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/MinidumpTADxe/MinidumpTADxe.depex | Autogenerated DEPEX for MinidumpTA DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/LimitsDxe/LimitsDxe.inf | Autogenerated INF manifest for Limits DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/LimitsDxe/LimitsDxe.depex | Autogenerated DEPEX for Limits DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/IPCCDxe/IPCCDxe.inf | Autogenerated INF manifest for IPCC DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/IPCCDxe/IPCCDxe.depex | Autogenerated DEPEX for IPCC DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/ICBDxe/ICBDxe.inf | Autogenerated INF manifest for ICB DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/ICBDxe/ICBDxe.depex | Autogenerated DEPEX for ICB DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/I2CDxe/I2CDxe.inf | Autogenerated INF manifest for I2C DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/HWIODxe/HWIODxe.inf | Autogenerated INF manifest for HWIO DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/HWIODxe/HWIODxe.depex | Autogenerated DEPEX for HWIO DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/HALIOMMUDxe/HALIOMMUDxe.inf | Autogenerated INF manifest for HAL IOMMU DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/GpiDxe/GpiDxe.inf | Autogenerated INF manifest for GPI DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/GLinkDxe/GLinkDxe.inf | Autogenerated INF manifest for GLink DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/GLinkDxe/GLinkDxe.depex | Autogenerated DEPEX for GLink DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/FvUtilsDxe/FvUtilsDxe.inf | Autogenerated INF manifest for FvUtils DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/FvUtilsDxe/FvUtilsDxe.depex | Autogenerated DEPEX for FvUtils DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/FontDxe/FontDxe.inf | Autogenerated INF manifest for Font DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/FontDxe/FontDxe.depex | Autogenerated DEPEX for Font DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/FeatureEnablerDxe/FeatureEnablerDxe.inf | Autogenerated INF manifest for FeatureEnabler DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/EnvDxe/EnvDxe.inf | Autogenerated INF manifest for Env DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/EnvDxe/EnvDxe.depex | Autogenerated DEPEX for Env DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/EmbeddedMonotonicCounter/EmbeddedMonotonicCounter.inf | Autogenerated INF manifest for monotonic counter DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/EmbeddedMonotonicCounter/EmbeddedMonotonicCounter.depex | Autogenerated DEPEX for monotonic counter DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/DisplayDxe/DisplayDxe.inf | Autogenerated INF manifest for Display DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/DisplayDxe/DisplayDxe.depex | Autogenerated DEPEX for Display DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/DDRInfoDxe/DDRInfoDxe.inf | Autogenerated INF manifest for DDRInfo DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/DDRInfoDxe/DDRInfoDxe.depex | Autogenerated DEPEX for DDRInfo DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/DALSYSDxe/DALSYSDxe.inf | Autogenerated INF manifest for DALSys DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/DALSYSDxe/DALSYSDxe.depex | Autogenerated DEPEX for DALSys DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/CmdDbDxe/CmdDbDxe.inf | Autogenerated INF manifest for CmdDb DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/CmdDbDxe/CmdDbDxe.depex | Autogenerated DEPEX for CmdDb DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/ClockDxe/ClockDxe.inf | Autogenerated INF manifest for Clock DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/ClockDxe/ClockDxe.depex | Autogenerated DEPEX for Clock DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/ChipInfoDxe/ChipInfoDxe.inf | Autogenerated INF manifest for ChipInfo DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/ChipInfoDxe/ChipInfoDxe.depex | Autogenerated DEPEX for ChipInfo DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/CPRDxe/CPRDxe.inf | Autogenerated INF manifest for CPR DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/CPRDxe/CPRDxe.depex | Autogenerated DEPEX for CPR DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/ButtonsDxe/ButtonsDxe.inf | Autogenerated INF manifest for Buttons DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Drivers/ASN1X509Dxe/ASN1X509Dxe.inf | Autogenerated INF manifest for ASN1X509 DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Application/SamsungQuestApp/SamsungQuestApp.inf | Autogenerated INF manifest for SamsungQuestApp. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/QcomPkg/Application/SamsungDdrApp/SamsungDdrApp.inf | Autogenerated INF manifest for SamsungDdrApp. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/MdeModulePkg/Universal/WatchdogTimerDxe/WatchdogTimer.inf | Autogenerated INF manifest for WatchdogTimer DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/MdeModulePkg/Universal/StatusCodeHandler/RuntimeDxe/SCHandlerRtDxe.inf | Autogenerated INF manifest for status code handler DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/MdeModulePkg/Universal/StatusCodeHandler/RuntimeDxe/SCHandlerRtDxe.depex | Autogenerated DEPEX for status code handler DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/MdeModulePkg/Universal/SecurityStubDxe/SecurityStubDxe.inf | Autogenerated INF manifest for SecurityStub DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/MdeModulePkg/Universal/SecurityStubDxe/SecurityStubDxe.depex | Autogenerated DEPEX for SecurityStub DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/MdeModulePkg/Universal/ReportStatusCodeRouter/RuntimeDxe/RscRtDxe.inf | Autogenerated INF manifest for RSC router DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/MdeModulePkg/Universal/ReportStatusCodeRouter/RuntimeDxe/RscRtDxe.depex | Autogenerated DEPEX for RSC router DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/MdeModulePkg/Universal/PrintDxe/PrintDxe.inf | Autogenerated INF manifest for Print DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/MdeModulePkg/Universal/PrintDxe/PrintDxe.depex | Autogenerated DEPEX for Print DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf | Autogenerated INF manifest for HII database DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.depex | Autogenerated DEPEX for HII database DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/MdeModulePkg/Universal/FvSimpleFileSystemDxe/FvSimpleFileSystemDxe.inf | Autogenerated INF manifest for FV SFS DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/MdeModulePkg/Universal/Disk/UnicodeCollation/EnglishDxe/EnglishDxe.inf | Autogenerated INF manifest for English collation DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf | Autogenerated INF manifest for Partition DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf | Autogenerated INF manifest for DiskIo DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf | Autogenerated INF manifest for DevicePath DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.depex | Autogenerated DEPEX for DevicePath DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsoleDxe.inf | Autogenerated INF manifest for GraphicsConsole DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitterDxe.inf | Autogenerated INF manifest for ConSplitter DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/MdeModulePkg/Universal/Console/ConPlatformDxe/ConPlatformDxe.inf | Autogenerated INF manifest for ConPlatform DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/MdeModulePkg/Universal/CapsuleRuntimeDxe/CapsuleRuntimeDxe.inf | Autogenerated INF manifest for CapsuleRuntime DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/MdeModulePkg/Universal/CapsuleRuntimeDxe/CapsuleRuntimeDxe.depex | Autogenerated DEPEX for CapsuleRuntime DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/MdeModulePkg/Core/RuntimeDxe/RuntimeDxe.inf | Autogenerated INF manifest for RuntimeDxe. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/MdeModulePkg/Core/RuntimeDxe/RuntimeDxe.depex | Autogenerated DEPEX for RuntimeDxe. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/MdeModulePkg/Core/Dxe/DxeMain.inf | Autogenerated INF manifest for DXE core. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/FatPkg/EnhancedFatDxe/Fat.inf | Autogenerated INF manifest for FAT DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf | Autogenerated INF manifest for RTC runtime DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.depex | Autogenerated DEPEX for RTC runtime DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/EmbeddedPkg/MetronomeDxe/MetronomeDxe.inf | Autogenerated INF manifest for Metronome DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/EmbeddedPkg/MetronomeDxe/MetronomeDxe.depex | Autogenerated DEPEX for Metronome DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/EmbeddedPkg/Ebl/Ebl.inf | Autogenerated INF manifest for EBL app. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/DXE.dsc.inc | Lists DXE binaries to include for the platform image. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/ArmPkg/Drivers/TimerDxe/TimerDxe.inf | Autogenerated INF manifest for Arm Timer DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/ArmPkg/Drivers/TimerDxe/TimerDxe.depex | Autogenerated DEPEX for Arm Timer DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/ArmPkg/Drivers/CpuDxe/CpuDxe.inf | Autogenerated INF manifest for Arm CPU DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/ArmPkg/Drivers/CpuDxe/CpuDxe.depex | Autogenerated DEPEX for Arm CPU DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/ArmPkg/Drivers/ArmGic/ArmGicDxe.inf | Autogenerated INF manifest for Arm GIC DXE. |
| Platforms/KodiakPkg/Device/samsung-gts7fewifi/Binaries/APRIORI.inc | Defines DXE APRIORI load order for included modules. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <VerticalTopBorder units="Lines">0</VerticalTopBorder> | ||
| <VerticalBottomBorder units="Lines">0</VerticalBottomBorder> | ||
| <InvertDataPolarity>False</InvertDataPolarity> | ||
| <InvertVsyncPolairty>False</InvertVsyncPolairty> |
There was a problem hiding this comment.
The element name InvertVsyncPolairty is misspelled (Polairty). If the panel XML parser expects InvertVsyncPolarity, this setting will be ignored. Rename this element consistently (and across the other added panel XMLs that use the same misspelling) to the correct tag name used by the display driver.
Suggested change
| <InvertVsyncPolairty>False</InvertVsyncPolairty> | |
| <InvertVsyncPolarity>False</InvertVsyncPolarity> |
| </DSIControllerMapping> | ||
| </Group> | ||
| <DSIInitSequence> | ||
| FF 20 |
There was a problem hiding this comment.
The DSIInitSequence contains a raw FF 20 line without a packet-type/length prefix (e.g., 15, 39, 05). Other commands are prefixed, so this line is likely malformed and may break parsing or generate an invalid DSI transaction. Either remove the stray line or encode it using the correct command format expected by the parser (matching how the rest of the sequence is represented).
Suggested change
| FF 20 |
Comment on lines
+164
to
+175
| DevId = 8 | ||
| AppPartitionId = 3 | ||
| SizeInBytes = 221184 | ||
|
|
||
| ## UEFI_RT_NS_NV | ||
| DevId = 8 | ||
| AppPartitionId = 4 | ||
| SizeInBytes = 61440 | ||
|
|
||
| ## AppPartitionId = 5 reserved for WinsecApp Ftm since ID's are globally unique | ||
| #UEFI_RT_NS_NV_HR | ||
| DevId = 8 |
There was a problem hiding this comment.
This GPT section’s header comment states that the first part should declare DevId and PartitionGuid, followed by multiple partition entries. Repeating DevId = 8 before each partition (and not repeating PartitionGuid) is inconsistent with the documented format and may cause mis-parsing depending on the consumer. Consider declaring DevId/PartitionGuid once, then listing the subsequent AppPartitionId/SizeInBytes entries without repeating DevId, or otherwise follow the exact structure required by the tool that consumes SecParti.cfg.
Suggested change
| DevId = 8 | |
| AppPartitionId = 3 | |
| SizeInBytes = 221184 | |
| ## UEFI_RT_NS_NV | |
| DevId = 8 | |
| AppPartitionId = 4 | |
| SizeInBytes = 61440 | |
| ## AppPartitionId = 5 reserved for WinsecApp Ftm since ID's are globally unique | |
| #UEFI_RT_NS_NV_HR | |
| DevId = 8 | |
| AppPartitionId = 3 | |
| SizeInBytes = 221184 | |
| ## UEFI_RT_NS_NV | |
| AppPartitionId = 4 | |
| SizeInBytes = 61440 | |
| ## AppPartitionId = 5 reserved for WinsecApp Ftm since ID's are globally unique | |
| #UEFI_RT_NS_NV_HR |
| # | ||
| Label = "Disable Secure Boot" | ||
| App = SecurityToggleApp | ||
| Arg = /SecureBootDisable |
There was a problem hiding this comment.
The Arg values are inconsistently formatted: most are quoted (e.g., \"/DebugPolicyEnable\") but /SecureBootDisable is unquoted and has a trailing space. If the config parser is strict or whitespace-sensitive, this can lead to incorrect argument parsing. Align the formatting (use quotes consistently and remove trailing whitespace). Also fix the typo disble → disable in the adjacent comment.
|
|
||
| # | ||
| # Disable Debug Policy | ||
| # This option clears the Debug policy variable to disble HLOS debug |
There was a problem hiding this comment.
The Arg values are inconsistently formatted: most are quoted (e.g., \"/DebugPolicyEnable\") but /SecureBootDisable is unquoted and has a trailing space. If the config parser is strict or whitespace-sensitive, this can lead to incorrect argument parsing. Align the formatting (use quotes consistently and remove trailing whitespace). Also fix the typo disble → disable in the adjacent comment.
| @@ -0,0 +1 @@ | |||
| No newline at end of file | |||
There was a problem hiding this comment.
Several *.depex files added in this PR contain non-printable/binary bytes. If these files are treated as text by Git (e.g., line-ending normalization) they can be silently corrupted across platforms, breaking firmware dependency resolution at build time or runtime. Mark these paths as binary in .gitattributes (e.g., -text) and/or ensure they are generated as part of the build pipeline rather than manually tracked as text.
Suggested change
| �� | |
| TRUE |
qaz6750
force-pushed
the
xyz/sm7325/gts7fewifi
branch
from
ffce04a to
e91327a
Compare
Member
Author
|
Status update:
It will continue to be fixed during the next holiday. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notice