Skip to content

Docker Setup - #125

Merged
mirmirmirr merged 9 commits into
main-previewfrom
package-consistency
Apr 21, 2026
Merged

Docker Setup#125
mirmirmirr merged 9 commits into
main-previewfrom
package-consistency

Conversation

@mirmirmirr

Copy link
Copy Markdown
Contributor

This PR sets up docker for the CARPI-Site and updates the README instructions accordingly

To create and run inside a docker container, use docker compose up and docker compose down when done.

@mirmirmirr mirmirmirr changed the title Package consistency Docker Setup Apr 17, 2026
@mirmirmirr
mirmirmirr marked this pull request as ready for review April 17, 2026 15:31
Copilot AI review requested due to automatic review settings April 17, 2026 15:31

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds Docker-based developer (and partial production) containerization for the CARPI Site frontend, and updates documentation to describe running via Docker Compose.

Changes:

  • Expose the Vite dev server to all interfaces by default (vite --host) to support container access.
  • Add Docker Compose + Dockerfiles for containerized development and production builds.
  • Update README.md with Docker installation/run instructions.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
package.json Changes dev script to bind Vite on all interfaces (--host).
docker-compose.yml Adds a dev Compose service exposing 5173 and bind-mounting the repo.
README.md Adds Docker prerequisites + Docker run instructions.
Dockerfile.prod Adds multi-stage build to serve dist/ via nginx.
Dockerfile Adds a dev image that runs npm run dev.
.dockerignore Adds ignores to reduce Docker build context.
Comments suppressed due to low confidence (1)

README.md:120

  • The npm run dev bullet currently implies a localhost-only dev server, but the script now runs vite --host and will listen on all interfaces. Update the script descriptions here so they reflect the actual behavior (and any security implications) for local vs Docker usage.
- `npm run dev`: Start the Vite development server.
- `npm run build`: Type-check and create a production build.
- `npm run preview`: Preview the production build locally.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread package.json
Comment thread README.md Outdated
Comment thread Dockerfile.prod Outdated
Comment thread docker-compose.yml Outdated
@mirmirmirr
mirmirmirr requested a review from ramonechen April 17, 2026 15:39

@ramonechen ramonechen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The container spins up fine on my machine and the Docker configurations look good to me.

@mirmirmirr
mirmirmirr merged commit b5a734a into main-preview Apr 21, 2026
3 checks passed
@mirmirmirr
mirmirmirr deleted the package-consistency branch April 21, 2026 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants