Docker Setup - #125
Merged
Merged
Conversation
v0.1.0 CARPI Site
Fill in README
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Docker-based developer (and partial production) containerization for the CARPI Site frontend, and updates documentation to describe running via Docker Compose.
Changes:
- Expose the Vite dev server to all interfaces by default (
vite --host) to support container access. - Add Docker Compose + Dockerfiles for containerized development and production builds.
- Update
README.mdwith Docker installation/run instructions.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Changes dev script to bind Vite on all interfaces (--host). |
| docker-compose.yml | Adds a dev Compose service exposing 5173 and bind-mounting the repo. |
| README.md | Adds Docker prerequisites + Docker run instructions. |
| Dockerfile.prod | Adds multi-stage build to serve dist/ via nginx. |
| Dockerfile | Adds a dev image that runs npm run dev. |
| .dockerignore | Adds ignores to reduce Docker build context. |
Comments suppressed due to low confidence (1)
README.md:120
- The
npm run devbullet currently implies a localhost-only dev server, but the script now runsvite --hostand will listen on all interfaces. Update the script descriptions here so they reflect the actual behavior (and any security implications) for local vs Docker usage.
- `npm run dev`: Start the Vite development server.
- `npm run build`: Type-check and create a production build.
- `npm run preview`: Preview the production build locally.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ramonechen
approved these changes
Apr 21, 2026
ramonechen
left a comment
Contributor
There was a problem hiding this comment.
The container spins up fine on my machine and the Docker configurations look good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR sets up docker for the CARPI-Site and updates the
READMEinstructions accordinglyTo create and run inside a docker container, use
docker compose upanddocker compose downwhen done.