Skip to content

Remove deprecated functionality for v1.5 #8430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: dev
Choose a base branch
from

Conversation

KumoLiu
Copy link
Contributor

@KumoLiu KumoLiu commented Apr 25, 2025

remove deprecated functionality

Part of #8421

Description

Removed Functionality:

  • metrics: Removed compute_percent_hausdorff_distance. Use compute_hausdorff_distance with the percentile argument instead.
  • bundle: Removed net_name, net_kwargs, and return_state_dict arguments from load(). Use the model argument for network instantiation.
  • bundle: Removed workflow argument from BundleWorkflow and ConfigWorkflow. Use workflow_type instead.
  • networks: Removed img_size argument from SwinUNETR. Input size checks are now performed during forward().

Default Value Changes:

  • GeneralizedDiceScore: Changed default reduction from MEAN_BATCH to MEAN.
  • CropForeground / CropForegroundd: Changed default allow_smaller from True to False.
  • get_mask_edges: Changed default always_return_as_numpy from True to False.
  • generate_spatial_bounding_box: Changed default allow_smaller from True to False.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@KumoLiu KumoLiu requested a review from ericspod April 27, 2025 09:13
KumoLiu added 2 commits April 27, 2025 17:15
Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant