Update deps for monai bundle download #762
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Suraj Pai <[email protected]>
models/vista3d/docs/README.md
Outdated
| # Installation Guide | ||
| ``` | ||
| pip install "monai[fire]" | ||
| pip install "monai[fire]" requests huggingface_hub |
There was a problem hiding this comment.
Hi @surajpaib , thanks for the contribution.
Since the bundle content is changed, can you also update the metadata.json with a new version and changelog?
https://github.com/Project-MONAI/model-zoo/blob/dev/models/vista3d/configs/metadata.json#L5
There was a problem hiding this comment.
This is done now!
Signed-off-by: Suraj Pai <[email protected]>
Signed-off-by: Suraj Pai <[email protected]>
models/vista3d/configs/metadata.json
Outdated
| @@ -1,7 +1,8 @@ | |||
| { | |||
| "schema": "https://github.com/Project-MONAI/MONAI-extra-test-data/releases/download/0.8.1/meta_schema_20240725.json", | |||
| "version": "0.5.10", | |||
There was a problem hiding this comment.
HI @surajpaib here also need to be changed to 0.5.11
Signed-off-by: Suraj Pai <[email protected]>
|
/build |
ericspod
reviewed
Nov 4, 2025
| # Installation Guide | ||
| ``` | ||
| pip install "monai[fire]" | ||
| pip install "monai[fire,ignite]" requests huggingface_hub |
There was a problem hiding this comment.
These added requirements can be mentioned in required_packages_version in the metadata file as well.
|
@yiheng-wang-nv please review again when you can and approve if we're good, @KumoLiu may be needed to trigger blossom if it's not working for you. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update deps for monai bundle download
monai bundle download commands fails without requests and huggingface_hub