-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Francisco briceno #2
Open
fjavier
wants to merge
27
commits into
Project5Q:master
Choose a base branch
from
fjavier:francisco-briceno
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Welcome is the home page of the app.
creating JS in the view, this is not so Ok. but by now i just wanna play with The RxJs: I created a Observable for the request and response from the API. I made a Observable Stream to control some actions for each minute. I made a function to get BPI (Bitcoin Price Index) results, from the stream Response. And the best part(It work.git commit -m
creating JS in the view, this is not so Ok. but by now i just wanna play with The RxJs: I created a Observable for the request and response from the API. I made a Observable Stream to control some actions for each minute. I made a function to get BPI (Bitcoin Price Index) results, from the stream Response. And the best part(It work)
β¦olling average. Show at the user a diferente msg at the user, if the length is less than 5.
Fix function Calculate Rolling Average (it function get The rolling average from the last five prices)
The rolling average is just the calculate of n elements given. The array bpiList stored all the values getting of the response and the array grows exponentially. The buffer got the elements of a stream of the array. this method to calculate the average consuming many resources. The solution: push the elments in the array, when have a lenght of five elements, calculate the rolling average and shift the first element of the array. when the next value is comming then push the value at the array. in this manner the array ever will have 5 elements and the calculation will be faster.
Stream get data and rendered in each column. The columns are waiting the values. The rolling average is appended at the table, in the column where wait the data, rendered the msg: please wait.
Move the app to a file js. show the time left to pudate the current price.
Move all the inline styles in document at file .css Footer added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greetings,
I complete the challenge. π β β