-
Notifications
You must be signed in to change notification settings - Fork 5
Remove xarray pin in environment; call dask compute on the two data a… #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…rrays; current version of Panel fixes time slider in rasterized dataset
👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below. |
For some reason the preview never deployed. Rerunning the build to see if that fixes it. |
Now the build has failed. Taking a look. |
I ran the notebooks and build the cookbook locally no problem. It's not clear to me what's failing on GitHub. Will try closing and reopening aka unplugging the router. |
So the failure has nothing to do with executing the notebooks, which is working fine. It's actually the sphinx theme that is failing:
Fun! |
There must be a package conflict in the sphinx / jupyter-book stack. I will investigate elsewhere. |
So this is frustrating. I used the exact same environment description in this PR on the Cookbook template and did not reproduce the same failure. Somehow the two builds are ending up different despite having the same contents in At the end of the
Over at ProjectPythia/cookbook-template#130 the same stage of the build log says
Basically it looks like pip is downgrading several packages in the sphinx stack to satisfy the requirement to use an old version of Why is the same thing not happening in this PR? I have no idea right now. |
I'll try pinning those packages in the environment file here so mamba installs the correct versions. But it would be great to understand what's causing the failure and/or how to reproduce it. |
Pinning to
caused a different build failure when I ran it locally. Not sure where to go from here. |
Very interesting/confounding, since I believe the trigger-book-build action succeeded last night after I modified 01BasicVisualization.ipynb with the necessary dask.compute call. Definitely makes the need to modernize the sphinx-pythia-theme more immediate. |
…rrays; current version of Panel fixes time slider in rasterized dataset