Skip to content

Move myst.yml and adapt workflows #519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 19, 2025

Conversation

brian-rose
Copy link
Member

Closes #517

This PR moves the myst.yml file into the /portal/ directory, mirroring the previous organization of this repo, wherein the old _config.yml lived in the subdirectory and Jupyterbook builds were run from the subdirectory.

This will resolve the problem of spurious /portal showing up in URLs of rendered pages, as described in #517 and #516, and will thus restore many existing links that are currently broken.

It will also make this repo more consistent with what we describe in our various Contributor guides.

Copy link
Contributor

github-actions bot commented Jun 19, 2025

👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below.
🔍 Git commit SHA: 456a7c4
✅ Deployment Preview URL: https://projectpythia.github.io/_preview/519

@brian-rose
Copy link
Member Author

Preview deployment will fail here until this PR is merged, because this PR changes the build path and that workflow needs to be in main before it can be used.

@brian-rose brian-rose marked this pull request as ready for review June 19, 2025 11:44
@brian-rose brian-rose requested a review from a team as a code owner June 19, 2025 11:44
@brian-rose brian-rose requested review from ktyle, jukent and dcamron and removed request for a team June 19, 2025 11:44
@ktyle
Copy link
Contributor

ktyle commented Jun 19, 2025

@brian-rose it looks like style.css needs to be moved from the top-most directory into the portal directory.

@brian-rose
Copy link
Member Author

@brian-rose it looks like style.css needs to be moved from the top-most directory into the portal directory.

ah, that makes sense.

@brian-rose
Copy link
Member Author

There's something wrong with the preview path still, I will fix.

@brian-rose
Copy link
Member Author

No, I think it's correct, it just won't take effect until this PR is merged. So I'll merge and check another PR.

@brian-rose brian-rose merged commit f0e3be6 into ProjectPythia:main Jun 19, 2025
2 checks passed
@brian-rose brian-rose deleted the reorganize branch June 19, 2025 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

URLs have a spurious /portal/ in them
2 participants