-
Notifications
You must be signed in to change notification settings - Fork 22
Move myst.yml and adapt workflows #519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below. |
Preview deployment will fail here until this PR is merged, because this PR changes the build path and that workflow needs to be in main before it can be used. |
@brian-rose it looks like |
ah, that makes sense. |
There's something wrong with the preview path still, I will fix. |
No, I think it's correct, it just won't take effect until this PR is merged. So I'll merge and check another PR. |
Closes #517
This PR moves the
myst.yml
file into the/portal/
directory, mirroring the previous organization of this repo, wherein the old_config.yml
lived in the subdirectory and Jupyterbook builds were run from the subdirectory.This will resolve the problem of spurious
/portal
showing up in URLs of rendered pages, as described in #517 and #516, and will thus restore many existing links that are currently broken.It will also make this repo more consistent with what we describe in our various Contributor guides.