-
Notifications
You must be signed in to change notification settings - Fork 22
Get metrics working #522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get metrics working #522
Conversation
👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below. |
It would be useful to be notified of failures in the metrics script at build time. Related to ProjectPythia/cookbook-actions#150 Opened a separate issue for that: #523 |
Now the environment seems to fully specified. We have a new failure. The line
generates
indicating that the PRIVATE_KEY has not been set in the repo secrets. This is probably still over at https://github.com/projectpythia-mystmd/projectpythia-mystmd.github.io |
The metrics script was developed along with this deploy.yml that explicitly sets We need to adapt the build workflow used here to do something similar. |
Workflows adapted to handle these two secrets: ProjectPythia/cookbook-actions#151 |
The limitation here is that the metrics build still won't work for pull requests, because the PR branch that triggers the build will not have access to the secrets. I'm not sure how to get around that. That would definitely complicate #523 if all PR builds report failure because they can't run the metrics scripts. |
So I think the current status of this PR is that it will fix the broken metrics script for deployments that originate from the main repo (e.g. on merge of this PR, or on nightly builds). But I can't test that without merging the PR. |
I think this is all set now, but again, can't really tell if the metrics will work until after merging. |
Closes #521
Seeing if including Jupyterlab in the environment file resolves the build-time failure of the metrics script.This PR attempts to fix the broken metrics script. Two key changes:
environment.yml
build-book.yml
workflow where myst build is called.Limitation (discussed inline below): Can't pass the secrets for Pull Requests that originate from other forks. So metrics won't build in the previews. Including this preview.