Skip to content

3129 Gallery Sidebar Not Visible #3615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cyrusnaficy wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

3129 Gallery Sidebar Not Visible #3615

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ffdfebe
fix view but not scroll
cyrusnaficy Aug 13, 2024
0838383
fixed gallery view scroll
cyrusnaficy Aug 27, 2024
b932003
Merge branch 'develop' into 3129-gallery-sidebar-not-visible
cyrusnaficy Aug 27, 2024
753b197
update
cyrusnaficy Sep 9, 2024
9d7e595
Merge branch 'develop' into 3129-gallery-sidebar-not-visible
cyrusnaficy Sep 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion public/javascripts/Gallery/css/gallery.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
/* Note that the side bar is out of the "flow" of the grid container b/c it is fixed when we aren't loading anything. */
.sidebar {
padding-left: 10px;
min-height: calc(100vh - 610px);
min-height: 100vh;
height: 100%;
width: 239px;
grid-row: 1/2;
Expand Down Expand Up @@ -90,6 +90,8 @@
'main gallery-modal'
'paging gallery-modal';
grid-gap: 2px;
margin-bottom: 10px;
min-height: 70vh;
padding: 0 10px 10px 10px;
}

Expand Down
2 changes: 1 addition & 1 deletion public/javascripts/Gallery/src/cards/CardContainer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,7 +338,7 @@ function CardContainer(uiCardContainer, initialFilters) {
sg.ui.cardFilter.wrapper.css('position', 'fixed');
sg.ui.cardFilter.wrapper.css('top', '');
uiCardContainer.holder.css('margin-left', sg.ui.cardFilter.wrapper.css('width'));
sg.scrollStatus.stickySidebar = true;
imagePromises.length >= 6 ? sg.scrollStatus.stickySidebar = true : sg.scrollStatus.stickySidebar = false;
sg.cardFilter.enable();
});
} else {
Expand Down