Credentials: Custom Provider Input #166

[priyanshu6238]

Current State

• Single-provider, rigid structure: Only one provider's credentials could be stored per organization, with a fixed structure and no support for provider-specific operations or validation.
• Insecure deletion & inconsistent responses: Credential deletions were not safely handled (no soft deletion or data clearing), and API responses lacked standardization, leading to error-prone client handling.
• No API key encryption for api_key in credentials.
• No update granularity: Updating credentials replaced the entire object instead of allowing partial updates (e.g., rotating only a secret without touching metadata), which is inefficient and risky.
• Missing input validation: Routes accepted loosely validated data (e.g., empty strings, invalid JSON) without proper checks, leading to internal crashes and unexpected behavior.
• No error normalization: Errors like missing providers, invalid orgs, or DB issues were returned with inconsistent status codes or vague messages, complicating debugging and error handling.
• Missing input validation: Routes accepted loosely validated data (e.g., empty strings, invalid JSON) without proper checks, leading to internal crashes and unexpected behavior.

Key Changes

• Multi-provider support:
  Enabled storing credentials for multiple providers (e.g., OpenAI, Gemini) per organization.

• Flexible credential structure:
  Refactored data model to handle provider-specific credential fields dynamically.

• Soft deletion logic:
  Credentials are marked as inactive instead of being permanently deleted, allowing safer recovery.

• Isolated provider updates:
  Updates apply only to the specified provider without overwriting other credentials.

• Improved error handling:
  Clear and appropriate HTTP status codes are used (400, 404, 500) to aid client-side debugging.

• Provider verification:
  Ensured that only supported providers can be added or updated using validate_provider().

• Ran fastapi run --reload app/main.py or docker compose up in the repository root and test.

• If you've fixed a bug or added code that is tested and has test cases.

[codecov]

Codecov Report

Attention: Patch coverage is 85.17350% with 47 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
backend/app/crud/credentials.py	71.42%	26 Missing ⚠️
backend/app/api/routes/credentials.py	66.10%	20 Missing ⚠️
backend/app/core/providers.py	96.29%	1 Missing ⚠️

📢 Thoughts on this report? Let us know!

[AkhileshNegi]

cherry picked it here
#179