Threads endpoints: credentials fetching refactoring#223
Closed
Threads endpoints: credentials fetching refactoring#223
Conversation
Collaborator
|
@nishika26 did you test it? It should work like this:
|
AkhileshNegi
requested changes
Jun 13, 2025
Collaborator
|
Also fetching credentials from database, is this implemented across modules? Like even with collections endpoint and file upload? |
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
Collaborator
|
@nishika26 @AkhileshNegi will be closing this PR due to #249, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Target issue is #210
Explain the motivation for making this change. What existing problem does the pull request solve?
for #210 -
-Langfuse credentials are now optional, allowing the endpoint to function even if Langfuse keys are not configured.
-This change provides more flexibility in the API by making OpenAI credentials the only required ones, while still supporting Langfuse if it’s available.
###NOTES