Add Missing Logs Across Platform for Key Events and Actions#235
Closed
avirajsingh7 wants to merge 11 commits intomainfrom
Closed
Add Missing Logs Across Platform for Key Events and Actions#235avirajsingh7 wants to merge 11 commits intomainfrom
avirajsingh7 wants to merge 11 commits intomainfrom
Conversation
Codecov ReportAttention: Patch coverage is 📢 Thoughts on this report? Let us know! |
nishika26
requested changes
Jun 19, 2025
|
|
||
| logger = logging.getLogger(__name__) | ||
| router = APIRouter(tags=["private"], prefix="/private") | ||
|
|
Collaborator
There was a problem hiding this comment.
I do not think that we need to implement logging in this file since it is not being used, and also not needed for project_user route as well since we already have a project user relationship with the api key generation
Collaborator
Author
There was a problem hiding this comment.
lets just keep it, may be if we need in future or if we remove code logging will be removed also
| logger = logging.getLogger(__name__) | ||
|
|
||
|
|
||
| def is_project_admin(session: Session, user_id: int, project_id: int) -> bool: |
This was
linked to
issues
Jun 20, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces comprehensive logging across the platform to improve observability, traceability, and debugging efficiency.
Target issue : #213 and #234