Skip to content

Evaluation table UI & Handle Temp Value for GPT-5 models #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ayush8923 merged 4 commits into from
Apr 6, 2026
Merged

Evaluation table UI & Handle Temp Value for GPT-5 models #104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e5ce9ac
fix(*): fix the evaluation table UI
Ayush8923 Apr 2, 2026
687c6d1
fix(*): use tailwind
Ayush8923 Apr 2, 2026
60045ae
fix(*): handle the temp for gpt-5 model
Ayush8923 Apr 3, 2026
69060fa
fix(*): handle the temp for gpt-5 model
Ayush8923 Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 13 additions & 9 deletions app/components/ConfigCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,15 +252,19 @@ export default function ConfigCard({
{latestVersion.modelName}
</span>
</div>
<div
className="px-2.5 py-1 rounded-md text-xs"
style={{ backgroundColor: colors.bg.secondary }}
>
<span style={{ color: colors.text.secondary }}>Temp: </span>
<span style={{ color: colors.text.primary, fontWeight: 500 }}>
{latestVersion.temperature.toFixed(2)}
</span>
</div>
{latestVersion.temperature != null && (
<div
className="px-2.5 py-1 rounded-md text-xs"
style={{ backgroundColor: colors.bg.secondary }}
>
<span style={{ color: colors.text.secondary }}>Temp: </span>
<span
style={{ color: colors.text.primary, fontWeight: 500 }}
>
{latestVersion.temperature.toFixed(2)}
</span>
</div>
)}
</div>

{/* Tools Dropdown */}
Expand Down
2 changes: 1 addition & 1 deletion app/components/ConfigDrawer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -537,7 +537,7 @@ export default function ConfigDrawer({
</div>

{/* Temperature */}
{!isGpt5 && (
{!isGpt5 && currentConfig.temperature != null && (
<div>
<label
style={{
Expand Down
2 changes: 1 addition & 1 deletion app/components/ConfigSelector.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -688,7 +688,7 @@ export default function ConfigSelector({
className="text-sm font-mono"
style={{ color: colors.text.primary }}
>
{selectedConfig.temperature.toFixed(2)}
{selectedConfig.temperature!.toFixed(2)}
</div>
</div>
)}
Expand Down
56 changes: 9 additions & 47 deletions app/components/DetailedResultsTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ export default function DetailedResultsTable({
>
{/* Table Container */}
<div className="overflow-x-auto">
<table className="w-full border-collapse" style={{ minWidth: "800px" }}>
<table className="w-full border-collapse min-w-[800px] table-fixed">
{/* Table Header */}
Copy link
Copy Markdown
Collaborator

@Prajna1999 Prajna1999 Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove GPT-4, GPT-4-Turbo and GPT-3.5-turbo as they are supeceded/or deprecated for better models. In the right configuration pane Type for Speech-to-Text and Text-to-Speech should be unselectable from the dropdown.

Copy link
Copy Markdown
Collaborator Author

@Ayush8923 Ayush8923 Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can handle this in another PR. The reason is that if I remove it for STT or TTS, I’ll need to recheck the entire flow and ensure there are no breaking changes. So for now, I want to avoid including it in this PR and proceed with a safe release.

Copy link
Copy Markdown
Collaborator

@Prajna1999 Prajna1999 Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the STT/TTS type was not enabled so nothing should break imo, but I think you are right. Approving

Copy link
Copy Markdown
Collaborator Author

@Ayush8923 Ayush8923 Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I will remove these models from STT/TTS flow in another PR.

<thead>
<tr
Expand Down Expand Up @@ -218,10 +218,7 @@ export default function DetailedResultsTable({
row.style.backgroundColor = "#ffffff";
}}
>
<td
className="px-4 py-3 text-sm font-medium align-top"
style={{ color: "#737373" }}
>
<td className="px-4 py-3 text-sm font-medium align-top text-text-secondary">
{index + 1}
</td>

Expand All @@ -230,14 +227,7 @@ export default function DetailedResultsTable({
className="px-4 py-3 align-top"
style={{ backgroundColor: "#fafafa" }}
>
<div
className="text-sm overflow-auto"
style={{
color: "#171717",
lineHeight: "1.5",
maxHeight: "150px",
}}
>
<div className="text-sm overflow-auto text-[#171717] leading-normal max-h-[150px] wrap-break-word">
{question}
</div>
</td>
Expand All @@ -247,28 +237,14 @@ export default function DetailedResultsTable({
className="px-4 py-3 align-top"
style={{ backgroundColor: "#fafafa" }}
>
<div
className="text-sm overflow-auto"
style={{
color: "#171717",
lineHeight: "1.5",
maxHeight: "150px",
}}
>
<div className="text-sm overflow-auto text-[#171717] leading-normal max-h-[150px] wrap-break-word">
{groundTruth}
</div>
</td>

{/* Answer */}
<td className="px-4 py-3 align-top">
<div
className="text-sm overflow-auto"
style={{
color: "#171717",
lineHeight: "1.5",
maxHeight: "150px",
}}
>
<div className="text-sm overflow-auto text-[#171717] leading-normal max-h-[150px] wrap-break-word">
{answer}
</div>
</td>
Expand Down Expand Up @@ -487,28 +463,14 @@ function GroupedResultsTable({ traces }: { traces: GroupedTraceItem[] }) {

{/* Question */}
<td className="px-4 pt-3 pb-1 align-top bg-[#fafafa]">
<div
className="text-sm overflow-auto"
style={{
color: "#171717",
lineHeight: "1.5",
maxHeight: "150px",
}}
>
<div className="text-sm overflow-auto text-[#171717] leading-normal max-h-[150px] wrap-break-word">
{group.question}
</div>
</td>

{/* Ground Truth */}
<td className="px-4 pt-3 pb-1 align-top bg-[#fafafa]">
<div
className="text-sm overflow-auto"
style={{
color: "#171717",
lineHeight: "1.5",
maxHeight: "150px",
}}
>
<td className="px-4 pt-3 pb-1 align-top bg-bg-secondary">
<div className="text-sm overflow-auto text-[#171717] leading-normal max-h-[150px] wrap-break-word">
{group.ground_truth_answer}
</div>
</td>
Expand All @@ -522,7 +484,7 @@ function GroupedResultsTable({ traces }: { traces: GroupedTraceItem[] }) {
className="px-4 pt-3 pb-1 align-top"
>
{answer ? (
<div className="text-sm overflow-auto text-[#171717] leading-6 max-h-[150px]">
<div className="text-sm overflow-auto text-[#171717] leading-6 max-h-[150px] wrap-break-word">
{answer}
</div>
) : (
Expand Down
28 changes: 15 additions & 13 deletions app/components/prompt-editor/DiffView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,20 +341,22 @@ export default function DiffView({
{selectedCommit.modelName}
</div>
</div>
<div>
<div
className="text-xs font-semibold mb-1"
style={{ color: colors.text.secondary }}
>
Temperature
</div>
<div
className="text-sm"
style={{ color: colors.text.primary }}
>
{selectedCommit.temperature}
{selectedCommit.temperature != null && (
<div>
<div
className="text-xs font-semibold mb-1"
style={{ color: colors.text.secondary }}
>
Temperature
</div>
<div
className="text-sm"
style={{ color: colors.text.primary }}
>
{selectedCommit.temperature}
</div>
</div>
</div>
)}
{selectedCommit.tools &&
selectedCommit.tools.length > 0 && (
<div>
Expand Down
Loading