-
Notifications
You must be signed in to change notification settings - Fork 630
Allow alias To: address in the event attendee list #447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
dinvlad
wants to merge
10,000
commits into
ProtonMail:main
Choose a base branch
from
dinvlad:fix-calendar-invite-participant-list
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Allow alias To: address in the event attendee list #447
dinvlad
wants to merge
10,000
commits into
ProtonMail:main
from
dinvlad:fix-calendar-invite-participant-list
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update Playwright See merge request web/clients!17749
[IDTEAM] 1.32.0 changelogs See merge request web/clients!17750
Fix gateway table display in responsive See merge request web/clients!17754
[IDTEAM] Update custom item text from "More" to "Other" See merge request web/clients!17758
Sync drive-store See merge request web/clients!17757
[refactoring/DRVWEB-4791] MoveToFolder SDK implementation See merge request web/clients!17596
Fix dumb className See merge request web/clients!17763
[IDTEAM] Move basic-auth autofill behind feature flag See merge request web/clients!17764
Improvements for SEPA See merge request web/clients!17656
Unlock @swc/core See merge request web/clients!17776
…main' [MSA-675] B2B Trials: use Organization.IsBusiness in useIsB2BTrial See merge request web/clients!17741
…' into 'main' Filter read messages from incoming messages so that unread notification gets hidden See merge request web/clients!17511
… into 'main' Remove arrow shortcuts in advanced search See merge request web/clients!17688
- Introduce `FileIdentifier` discriminated union type for better type safety - Use `FILE_PENDING_SHARE` constant for pending file unique IDs - Remove redundant `shareId` parameters from pending file operations - Allow users to change target share during upload process
6f16c41 to
c5e6ffe
Compare
1e4ffe8 to
8c63f2f
Compare
e991d10 to
7f5dbf2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi folks,
I'm trying to address a long-standing issue when the email address used in the To: header is one of alias addresses (such as those in SimpleLogin), but the attendee list in event invitation email is checked only against the list of Proton mail addresses.
As a result, currently the user sees
Your email address is not in the original participants list.warning, instead ofAdd to Proton Calendarbutton. This is frustrating for many users who have been using SimpleLogin aliases, as we have to then go through many clicks in Calendar app settings to import the event from the .ics file:https://protonmail.uservoice.com/forums/284483-proton-mail/suggestions/45483934-allow-adding-a-calendar-invite-to-proton-calendar
This PR aims to address this issue by comparing
To:field with the attendee list, in addition to existing logic for comparing attendees. Please let me know if you approve of the general idea, and I'll comb through the tests a bit more.Thanks!