fix: issue with slices.SortFunc #168
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
major0
commented
Jan 16, 2025
major0
commented
|
go-proton-api imports golang.org/x/exp/slices which had this issue associated to it: golang/go#61374 So go-proton-api's SortFunc was written against the experimental slices behavior. The experimental line was rewritten to match the production slices, and go-proton-api was never updated to deal with it. |
major0
force-pushed
the
fix/slices-sort
branch
from
6314686 to
abf837a
Compare
> address.go:21:33: in call to slices.SortFunc, type func(a Address, b Address) bool of func(a, b Address) bool {…} does not match inferred type func(a Address, b Address) int for func(a E, b E) int
major0
force-pushed
the
fix/slices-sort
branch
from
abf837a to
574b3be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.