Forward Optional projections after final SSA#29543
Conversation
26df0e7 to
7338a73
Compare
c3a7edc to
d5e58cb
Compare
68d9193 to
c08dd69
Compare
7c18038 to
54abe4b
Compare
54abe4b to
f3affcd
Compare
f3affcd to
e83479e
Compare
e83479e to
9172202
Compare
|
@mohammadfawaz I kept alias forwarding limited to generated |
Signed-off-by: 1sgtpepper <cynejarviszarceno@gmail.com>
IGI-111
left a comment
There was a problem hiding this comment.
I don't really like this solution, having partial application of some pass using some new syntax is confusing and error prone. We don't really know what has or hasn't been lowered at a given point.
I'd much rather we delay all options lowering and handle it in the intermediary passes if necessary or (and this is probably preferred) have a late optimization pass that notices and simplifies the pattern reliably.
|
Yeah, that makes sense. The partial const-prop entry point is awkward, and one The late peephole sounds like the better fit. I'd keep |
…st-prop-alias-v11
Summary
Part of #29343.
Removes redundant lowered
Optionalwrappers in the post-codegen peephole pass. The rewrites require compiler-generated identity, exact operands, and safe use counts; differing fallbacks retain both selections.Test Plan