[Fix] Overhaul slipstream plugin setup/framework#3267
Draft
dgrkotsonis wants to merge 4 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slipstream plugin manager: static-only architecture with inventory self-registration
Motivation
The original implementation used #[no_mangle] C FFI to load plugins as .so/.dylib files at runtime via libloading. We've since reevaluated that need, as Rust's lack of a stable ABI makes dynamic loading of trait objects an inherent production risk, and the decoupling benefit it offered is still mostly preserved. Static linking with inventory self-registration is the cleaner and safer approach.
Changes Made
resolve_libpath_from_config(), load_plugin_from_config(), the Library::from(this()) shim, and the libloading/json5 dependencies