fix order of operations for loading college plays#14
Open
Kazink36 wants to merge 1 commit intoPuntalytics:masterfrom
Open
fix order of operations for loading college plays#14Kazink36 wants to merge 1 commit intoPuntalytics:masterfrom
Kazink36 wants to merge 1 commit intoPuntalytics:masterfrom
Conversation
…hbacks for college plays
Member
|
Looks good to me; can you just merge in the below so that the workflow will run (I think)? And then should be good to go! Also, can you bump the version number to 1.4 on your fork, so that gets updated upon the merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I embarrassingly should have found this an age ago but the order of operations were wrong in loading college data and the net yardage on touchbacks was calculated incorrectly. I tested the change and yardage on touchback punts look correct now