Add support for timeout variable in client settings function get_target_versions #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add MAX_TIMEOUT int variable to the get request of get_target_versions
timeout variable is used in function get_array_versions, which is passed along to get_target_versions
…eout parameter Include the integer MAX_TIMEOUT with value of 120 seconds; calculate the timeout integer value between 1 and MAX_TIMEOUT
timeout variable is used in function get_array_versions, which is passed along to get_target_versions
DEFAULT_TIMEOUT is set to 5 seconds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When instantiating either the FlashArray or the FlashBlade Client, it can take a while to determine if the host is unreachable. The timeout parameter is not being passed to get_target_versions when passed to the Client.
Solution
[X] Pass the timeout variable when
Clientis first getting the target versions[X] Create a variable
MAX_TIMEOUTto prevent excessively long timeouts.[X] Create a variable
DEFAULT_TIMEOUTin the event None is passed[X] Set the timeout to between 1 and
MAX_TIMEOUTin the GET request