Update two type stubs for the use of None
#2015
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since `VideoFrame` does not override the `pts` setter/getter, it can also be `None` here. Instead of writing it out in the stubs, we can just reuse the definition from `Frame` by removing the stub in `VideoFrame`.
`None` is correctly handled to signify EOF to the buffer, but this should also be visible in the type stub.
|
@WyattBlue, thanks for merging so fast 😅 I had missed the typing problem in the tests though. Maybe should add some assertions there to satisfy Mypy? |
|
Yes, that would be great |
|
Alright, see #2016 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see the individual commits for the reasoning.
I found these issues using Mypy.