Fix signature #114
Closed
Fix signature #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: HanslettTheDev <[email protected]>
requirements.txt
Outdated
| git+https://github.com/pysimplesoap/pysimplesoap.git@py311#pysimplesoap; | ||
| cryptography==3.3.2; python_version <= '2.7' | ||
| cryptography==3.4.7; python_version > '3' | ||
| cryptography==41.0.0; python_version > '3' |
Member
There was a problem hiding this comment.
Hi @HanslettTheDev!. Check the cryptography version for python 3. There is no 41 yet. The last in pypi is 40.0.2 and @salticus in his update uses 39.0.2 version.
Collaborator
Author
There was a problem hiding this comment.
Thanks, I think i will fix that as well. I'm still making some changes
NicolasSandoval
requested changes
May 31, 2023
wsaa.py
Outdated
| from cryptography.hazmat.primitives import serialization | ||
| from cryptography.hazmat.primitives.asymmetric import rsa | ||
| from cryptography.hazmat.bindings.openssl.binding import Binding | ||
| from cryptography.hamzat.primitives.serialization import pkcs7 |
Member
There was a problem hiding this comment.
Hi @HanslettTheDev! here is the typo flagged in discord
Collaborator
Author
There was a problem hiding this comment.
Oh I see the error now
I wrote instead hamzat instead of hazmat. Thanks Nico!
Signed-off-by: HanslettTheDev <[email protected]>
…dules Signed-off-by: HanslettTheDev <[email protected]>
…dules; commit signed Signed-off-by: HanslettTheDev <[email protected]>
Signed-off-by: HanslettTheDev <[email protected]>
fix: fixed the error when replacing the links with the module name The overall errors fixed was to prevent the setup.py build from failing Signed-off-by: HanslettTheDev <[email protected]>
… the clone of the pycon commit Signed-off-by: HanslettTheDev <[email protected]>
Signed-off-by: HanslettTheDev <[email protected]>
Signed-off-by: HanslettTheDev <[email protected]>
Signed-off-by: HanslettTheDev <[email protected]>
Signed-off-by: HanslettTheDev <[email protected]>
Signed-off-by: HanslettTheDev <[email protected]>
Signed-off-by: HanslettTheDev <[email protected]>
Signed-off-by: HanslettTheDev <[email protected]>
HanslettTheDev
force-pushed
the
fix_signature
branch
from
4282bf4 to
f1d312d
Compare
Signed-off-by: HanslettTheDev <[email protected]>
Signed-off-by: HanslettTheDev <[email protected]>
Signed-off-by: HanslettTheDev <[email protected]>
Signed-off-by: HanslettTheDev <[email protected]>
Signed-off-by: HanslettTheDev <[email protected]>
Signed-off-by: HanslettTheDev <[email protected]>
Signed-off-by: HanslettTheDev <[email protected]>
Signed-off-by: HanslettTheDev <[email protected]>
Signed-off-by: HanslettTheDev <[email protected]>
Signed-off-by: HanslettTheDev <[email protected]>
Co-authored-by: Nico Sandoval <[email protected]>
…signing method using pkcs7 and wrote a backward compatible code for python2.7 Signed-off-by: HanslettTheDev <[email protected]>
Signed-off-by: HanslettTheDev <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull requests aims to improve the work done in #113. Updating the cryptography module, fixing the broken tests and libraries
Checklist