Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #383.
The loop bound in _get_attribute_docstring_newlines shrank as the docstring index grew, so files with code before the attribute docstring collapsed two blank lines before a top-level def/class to one. This also ping-ponged with ruff format and Black. Scan to the end of the token list instead.
Verification: new parametrized regression in tests/formatter/test_do_format_code.py covers def and class, 0 to 3 blank lines, and early vs late file position, including idempotence. Full suite: 567 passed, 3 skipped. The issue repro with --diff and --check is clean for both snippets.