Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test coverage to Py3.7, Py3.8, Py3.9 #65

Merged
merged 1 commit into from
Oct 13, 2021

Conversation

javulticat
Copy link
Contributor

@javulticat javulticat commented Feb 14, 2021

This PR adds test coverage to Py3.7, Py3.8, and Py3.9. Related issue is #60. It also fixes the Py3.4 test, related issue being #61.

Looking at the output on Travis, it appears the test suite is working as expected with these changes.

However, I do have a few outstanding questions:

  1. It looks like Travis is using the config found in .travis.yml. So, what is the travis.yml file in this repo doing, if anything? Is that file still needed or can it be removed?
  2. Relatedly, it looks like travis.yml (which, again, AFAICT seems to not be doing anything) includes running isort, while .travis.yml (which appears to be what Travis is using) does not. Should we add the isort check to .travis.yml?
  3. By now, Py2.7, Py3.4 and Py3.5 have all reached EOL (on 2020-01-01, 2019-03-18, and 2020-09-05, respectively). Is test coverage still needed for these versions, in your opinion, or should it be removed similar to how coverage for Py3.3 was removed previously after its EOL?

Thanks!

@javulticat javulticat marked this pull request as draft February 14, 2021 20:42
@javulticat javulticat force-pushed the jav/add-test-cov-py37-py38-py39 branch 3 times, most recently from c191ab5 to 4f338f2 Compare February 14, 2021 20:57
@javulticat javulticat marked this pull request as ready for review February 14, 2021 21:19
@javulticat javulticat force-pushed the jav/add-test-cov-py37-py38-py39 branch from 4f338f2 to 920f0bd Compare February 14, 2021 21:22
@graingert graingert merged commit e3357c2 into PyCQA:master Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants