Open
Conversation
jcollins1983
approved these changes
Mar 14, 2026
Collaborator
jcollins1983
left a comment
jcollins1983
left a comment
There was a problem hiding this comment.
This one seems to duplicate content from PR #252, did you branch from that branch for this one?
At first I thought vtime was a horrible name for a function but it looks like you're just mirroring the VISA function name anyway, so I guess it makes sense.
Putting the break in paradigm aside, I think the change look reasonable.
| self.xmax = MeasureAllSources() | ||
| self.xmin = MeasureAllSources() | ||
|
|
||
| def vtime(self, time: float, channel: int): |
Collaborator
There was a problem hiding this comment.
This breaks the methodology used in definin all the other functions, but it's easier to understand since you don't have to go to a million other places to see what's going on, so I'm not opposed to the break in paradigm.
I'm assuming that implementing this is what led you to make the changes in #255
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Invert and Vtime functions are not currently implemented in the DSO function.
This PR is just adding them.