Closed
Conversation
Collaborator
|
Does this fix this issue also? #213 |
Collaborator
|
I believe all of these things are fixed in my branch that I'm going to revive and get finished #214 |
Collaborator
Author
|
Awesome, I'll close. |
Collaborator
Author
|
To be completed in #214 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bjorn pointed out that the get float function does not work when given 0.0 or 0 as a value.
Investigation shows that the return value checks simply
is ret_valwhich evaluates to false on 0.0 as its a falsy value.I have updated the implementation in the ui to explicitly check that ret_val is not None instead.