Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pyo3 requirement from 0.23 to 0.24 #33

Closed
wants to merge 2 commits into from
Closed

Conversation

0x676e67
Copy link

This pull request includes several updates to dependencies and minor improvements to the codebase. The most important changes include updating the pyo3 crate version, modifying the pyo3-async-runtimes-macros crate version, and enhancing the call_soon_threadsafe function in src/lib.rs.

Dependency updates:

Code improvements:

  • src/lib.rs: Enhanced the call_soon_threadsafe function by adding the pyo3::call::PyCallArgs trait to the args parameter.

@0x676e67
Copy link
Author

Should I upgrade pyo3-async-runtimes-macros to 0.24.0 as well?

@0x676e67
Copy link
Author

This fixes compilation of: #32

@cjdsellers
Copy link
Collaborator

Hi @0x676e67

Thank you for the contribution!

@kylebarron
Copy link
Contributor

I did the 0.23 upgrade (#21) and didn't expect someone else to also be doing this upgrade so fast, so I put up #34 as well. I don't have commit access to this repo so a committer can merge one or the other

@0x676e67
Copy link
Author

I did the 0.23 upgrade (#21) and didn't expect someone else to also be doing this upgrade so fast, so I put up #34 as well. I don't have commit access to this repo so a committer can merge one or the other

Haha, what a coincidence.

@davidhewitt
Copy link
Member

Thanks both, #34 looks slightly more complete so I will proceed with that one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants