Skip to content

use PyCallArgs for Py::call and friends #5206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 23, 2025
Merged

use PyCallArgs for Py::call and friends #5206

merged 1 commit into from
Jun 23, 2025
+12 −30

Conversation

Icxolu
Copy link
Contributor

@Icxolu Icxolu commented Jun 22, 2025

Switch Py::call and friends to also use PyCallArgs as their bound. This makes them equivalent to their Bound counterpart and allows them to use vectorcall if possible.

davidhewitt
davidhewitt approved these changes Jun 23, 2025
View reviewed changes
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice tidy up, thanks!

@Icxolu Icxolu added this pull request to the merge queue Jun 23, 2025
Merged via the queue into PyO3:main with commit e486930 Jun 23, 2025
43 of 45 checks passed
@Icxolu Icxolu deleted the pycallargs branch June 23, 2025 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhewitt davidhewitt davidhewitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Icxolu @davidhewitt