Introspection: implement output type #5208
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tpt
force-pushed
the
tpt/return-type
branch
2 times, most recently
from
7282dd7 to
84559e7
Compare
- Adds a new 'returns' field in the introspection data that contains the returned type annotation - Generate it using a new IntoPyObject::OUTPUT_TYPE associated constant (similar to INPUT_TYPE) - Add the internal PyReturnType trait to allow getting easily T::RETURN_TYPE when the function returns Result<T, E> - Take care of the special case of `()` converted to `None` and not `()` - Adding `OUTPUT_TYPE` to the `IntoPyObject` will be a follow-up (to avoid a huge PR)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
()converted toNoneand not()OUTPUT_TYPEto theIntoPyObjectwill be a follow-up (to avoid a huge PR)