remove uneeded Pin from PyBuffer
#5417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bschoenmaeckers
approved these changes
Sep 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was studying our buffer implementation in preparation to offer some solutions for #5245.
I think the
Pincomponent ofPyBuffer<T>is not needed. Quoting the Python documentation forbf_releasebuffer:This implies to me that the claim Python expects the buffer structure never to move is untrue. (I think this was originally introduced by me being overly cautious in the past.)
Anyway, with the diff proposed here the buffer structure is still heap allocated so that the
ffi::Py_bufferstructure still isn't moving.Marked as
CI-skip-changelogas I think this is purely internal.