Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add rule plot_balance_timeseries #1589

Merged
merged 6 commits into from
Mar 19, 2025
Merged

add rule plot_balance_timeseries #1589

merged 6 commits into from
Mar 19, 2025

Conversation

fneum
Copy link
Member

@fneum fneum commented Mar 17, 2025

Changes proposed in this Pull Request

Example:

image

image

image

Checklist

  • I tested my contribution locally and it works as intended.
  • Code and workflow changes are sufficiently documented.
  • Changed dependencies are added to envs/environment.yaml.
  • Changes in configuration options are added in config/config.default.yaml.
  • Changes in configuration options are documented in doc/configtables/*.csv.
  • Sources of newly added data are documented in doc/data_sources.rst.
  • A release note doc/release_notes.rst is added.

@fneum fneum requested a review from Copilot March 17, 2025 13:23
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new rule for plotting energy balance time series by introducing a new script and corresponding configuration changes.

  • Added the script scripts/plot_balance_timeseries.py to generate stacked area charts for energy balance data.
  • Updated config/config.default.yaml with new balance_timeseries settings including thresholds, resolutions, and carrier groups.

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

File Description
scripts/plot_balance_timeseries.py New plotting script for energy balance time series using stacked area charts.
config/config.default.yaml Added configuration parameters for balance_timeseries plotting.
Comments suppressed due to low confidence (1)

config/config.default.yaml:1059

  • The 'monthly_resolution' key is left without a value. Ensure that a valid resolution string is provided to avoid potential configuration errors.
monthly_resolution:

@fneum fneum added this to the v2025.03.0 milestone Mar 18, 2025
@fneum fneum merged commit 2b5e1f0 into master Mar 19, 2025
9 of 10 checks passed
@fneum fneum deleted the fneum/plot_balance_ts branch March 19, 2025 16:20
@Eric-Nitschke
Copy link
Contributor

@fneum at least for me, the changes of this PR lead to snakemake complaining:
The flag 'directory' used in rule all is only valid for outputs, not inputs.

However, it currently does not fully break it.

@fneum
Copy link
Member Author

fneum commented Mar 20, 2025

Yes, it will become a supported feature in snakemake 9 and does not hurt in 8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants