Skip to content

fix: define inflow_t before branch so it is always assigned #2224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fneum merged 3 commits into from
Jul 27, 2026
+3 −1
Merged

fix: define inflow_t before branch so it is always assigned #2224

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4a18dee
fix: define inflow_t before branch so it is always assigned
daniel-rdt Jul 7, 2026
d8db583
doc: add release note
daniel-rdt Jul 7, 2026
1014c58
Merge branch 'master' into fix/inflow-pylint
fneum Jul 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/release_notes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@

- doc: Disable root TOC entries in order to declutter the table of contents for the rules overview ([2216](https://github.com/PyPSA/pypsa-eur/pull/2216)).

* fix: Ensure `inflow_t` is always defined in `attach_hydro`, resolving a pylint use-before-assignment issue ([#2224](https://github.com/PyPSA/pypsa-eur/pull/2224)).
* Add missing regex anchor with `re.fullmatch` to `create_zenodo_deposition_cli` utils script ([#2225](https://github.com/PyPSA/pypsa-eur/pull/2225)).

## PyPSA-Eur v2026.02.0 (18th February 2026)
Expand Down
3 changes: 2 additions & 1 deletion scripts/add_electricity.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -770,6 +770,7 @@ def attach_hydro(
country = ppl["bus"].map(n.buses.country).rename("country")

inflow_idx = ror.index.union(hydro.index)
inflow_t = pd.DataFrame()
if not inflow_idx.empty:
dist_key = ppl.loc[inflow_idx, "p_nom"].groupby(country).transform(normed)

Expand Down Expand Up @@ -803,7 +804,7 @@ def attach_hydro(
capital_cost=costs.at["ror", "capital_cost"],
weight=ror["p_nom"],
p_max_pu=(
inflow_t[ror.index] # pylint: disable=E0606
inflow_t[ror.index]
.divide(ror["p_nom"], axis=1)
.where(lambda df: df <= 1.0, other=1.0)
),
Expand Down
Loading