Skip to content

Conversation

@Lumabots
Copy link
Contributor

@Lumabots Lumabots commented May 3, 2025

Summary

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters). Implement better get_or_fetch #1856
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@Lumabots
Copy link
Contributor Author

Lumabots commented May 3, 2025

feat from #1856

@Lumabots
Copy link
Contributor Author

Lumabots commented May 3, 2025

still not ready have some bug like : NameError: name 'VoiceChannel' is not defined
ig because of the type checking, i'll have to find a way to import it without circular import

@Paillat-dev
Copy link
Member

@Lumabots You can import it inside of the function where you use it directly instead of importing it at the top

@Lumabots
Copy link
Contributor Author

Lumabots commented May 3, 2025

@Lumabots You can import it inside of the function where you use it directly instead of importing it at the top

Well ig the issue come from the definition for the typevar, so will that resolve it ?

@Lumabots
Copy link
Contributor Author

Lumabots commented May 4, 2025

should be ready for review

@Lumabots
Copy link
Contributor Author

Lumabots commented May 4, 2025

just need to specify that this is breaking inside the changelog cos of modification of get_or_fetch and removal of get_or_fetch_user

Soheab
Soheab previously approved these changes Oct 11, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Member

@Paillat-dev Paillat-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm tested other than comments

@Lumabots Lumabots requested a review from Copilot October 19, 2025 17:30
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Member

@Paillat-dev Paillat-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm tested

@Lulalaby Lulalaby merged commit b9bfe00 into Pycord-Development:master Oct 20, 2025
28 checks passed
@Lumabots Lumabots deleted the get_or_fetch branch October 20, 2025 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants