Skip to content

feat: allow usage of unicode emoji in PartialEmojiConverter #2819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Lumabots
Copy link
Contributor

@Lumabots Lumabots commented Jun 24, 2025

Summary

Currently only custom emoji are supported by the converter, now unicode emoji (and other emoji) are supported.
I implemented a check that rely on #2815 to make sure the emoji is a valid unicode

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@Lumabots Lumabots requested a review from a team as a code owner June 24, 2025 22:51
@Lulalaby Lulalaby merged commit 3143637 into Pycord-Development:revert-2814-revert-2774-emoji Jun 24, 2025
5 of 8 checks passed
@Lumabots Lumabots deleted the partialemojiconverter branch June 24, 2025 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants