Time zone support DateTime input #252
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and not logged in, then to use browser timezone
|
I like the implementation choices (defaulting to hiding the zone, picking first from the user-configured zone and then the browser). We do need tests and docs before we can merge. |
|
Sorry, I'll close not to leave unmotivated PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #98
Added timezone supporting DateTime input Schema
By default, it won't be shown. but you can switch by passing
show_timezoneoption.Tasks
I know its "Work In Progress".
and If it can, separating timezone support datetime input from substanced and including on deform will be good.
If you have some opinion, everything is welcome.