Skip to content

Conversation

@eminyouskn
Copy link
Contributor

Fixes

The initial implementation of KNITRO does not properly handle the mapping of solution statuses in cases where a time or iteration limit is reached, even when a feasible solution is available.

Summary/Motivation:

Changes proposed in this PR:

  • Update the solution status when the iteration limit or time limit is reached on KNITRO.

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@mrmundt
Copy link
Contributor

mrmundt commented Oct 21, 2025

It might be worth adding some tests to ensure that the different statuses are caught!

@eminyouskn
Copy link
Contributor Author

@mrmundt that's a good idea. I will add them now then.

@eminyouskn eminyouskn changed the title Fix KNITRO solution status mapping [Depends on #3765] Fix KNITRO solution status mapping Oct 21, 2025
@eminyouskn
Copy link
Contributor Author

This PR is also ready.

@blnicho blnicho changed the title [Depends on #3765] Fix KNITRO solution status mapping Fix KNITRO solution status mapping Oct 28, 2025
@eminyouskn
Copy link
Contributor Author

@blnicho just to let you know, I added a link to the doc.

@codecov
Copy link

codecov bot commented Nov 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.23%. Comparing base (8397f66) to head (67b8f95).
⚠️ Report is 13 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3766   +/-   ##
=======================================
  Coverage   89.23%   89.23%           
=======================================
  Files         907      907           
  Lines      104817   104818    +1     
=======================================
+ Hits        93536    93538    +2     
+ Misses      11281    11280    -1     
Flag Coverage Δ
builders 29.16% <0.00%> (-0.01%) ⬇️
default 85.35% <100.00%> (?)
expensive 35.70% <0.00%> (?)
linux 86.68% <0.00%> (-2.32%) ⬇️
linux_other 86.68% <0.00%> (-0.01%) ⬇️
osx 82.81% <0.00%> (-0.01%) ⬇️
win 84.93% <0.00%> (-0.01%) ⬇️
win_other 84.93% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@blnicho blnicho merged commit 1137fe9 into Pyomo:main Nov 5, 2025
63 of 65 checks passed
@eminyouskn eminyouskn deleted the knitro-load-solutions branch November 5, 2025 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants