-
Notifications
You must be signed in to change notification settings - Fork 560
Fix KNITRO solution status mapping #3766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
It might be worth adding some tests to ensure that the different statuses are caught! |
|
@mrmundt that's a good idea. I will add them now then. |
|
This PR is also ready. |
|
@blnicho just to let you know, I added a link to the doc. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3766 +/- ##
=======================================
Coverage 89.23% 89.23%
=======================================
Files 907 907
Lines 104817 104818 +1
=======================================
+ Hits 93536 93538 +2
+ Misses 11281 11280 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Fixes
The initial implementation of KNITRO does not properly handle the mapping of solution statuses in cases where a time or iteration limit is reached, even when a feasible solution is available.
Summary/Motivation:
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: