Remove support for speakers and sessions #161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Hi @matrixise. Are you looking for another approval on this? |
Contributor
Author
|
I'm going to update this branch with the latest changes from master, and then I'll request a review from @ArcaneIRE. |
matrixise
force-pushed
the
remove-speakers
branch
from
bb4a763 to
e37ccab
Compare
ArcaneIRE
approved these changes
Nov 22, 2025
pythonie/pythonie/settings/base.py
Outdated
|
|
||
| # Absolute filesystem path to the Django project directory: | ||
| PROJECT_ROOT = dirname(dirname(dirname(abspath(__file__)))) | ||
| print(f'{PROJECT_ROOT=}') |
Contributor
Author
There was a problem hiding this comment.
Good catch, thank you and sorry for the delay!
- Resolved modify/delete conflicts by keeping speakers app deletion - Updated CLAUDE.md to remove references to speakers/sessions functionality - Merged latest changes from master including CI/CD improvements
- Removed speakers/sessions directory completely including remaining migrations - Updated CLAUDE.md to remove speakers app documentation - Updated README.md to remove speakers/sessions references - Updated CONTRIBUTING.md with alternative examples - Updated DEVELOPMENT.md to remove all speakers/sessions sections - Removed speakers.html template - Updated generate_sample_data.py to remove Speakers page creation - Updated .claude/commands/commit.md examples to use alternative models
- Removed pycon:import:sessionize task - Removed pycon:import:sessionize:json task These management commands no longer exist after speakers app removal.
Creates core migration 0010_remove_speakers_tables.py that: - Drops all database tables from the removed speakers app - Handles table dependencies correctly (CASCADE) - Drops tables in order: junction tables, then FK tables, then base tables - Is irreversible (requires backup to rollback) Tables dropped: - speakers_session_speakers (M2M junction table) - speakers_session - speakers_speaker - speakers_room - speakers_talkspage - speakers_speakerspage This migration should be run on production before deploying the code that removes the speakers app from INSTALLED_APPS.
Documents the complete deployment procedure including: - Pre-deployment checklist - Step-by-step migration instructions - Rollback procedure - Troubleshooting guide - Post-deployment cleanup This guide should be followed when deploying PR #161 to production.
Updates core.0010_remove_speakers_tables to: - Detect database vendor (PostgreSQL vs SQLite) - Use CASCADE only for PostgreSQL (not supported in SQLite) - Temporarily disable foreign keys for SQLite - Use f-strings for conditional CASCADE syntax This allows the migration to run on both development (SQLite) and production (PostgreSQL) environments. Tested successfully on SQLite - all speakers tables removed.
- Added django:migrate:postgres task to run migrations on PostgreSQL in docker-compose - Added django:showmigrations task to view migration status with PostgreSQL - Both tasks use pythonie.settings.pgdev for PostgreSQL database configuration Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
- Update quote style to use double quotes consistently Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the support of the speakers because we don't use them in the site.