Skip to content

Add precommit hooks #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 14, 2025

Conversation

jenshnielsen
Copy link
Collaborator

Add precommit hooks copied from qcodes.
For now this only enabled strib trailing whitespace and newlines.
Ruff is added but all rules disabled. These can gradually be enabled in a new pr

@jenshnielsen jenshnielsen enabled auto-merge March 14, 2025 14:33
Copy link

codecov bot commented Mar 14, 2025

Codecov Report

Attention: Patch coverage is 0% with 83 lines in your changes missing coverage. Please review.

Project coverage is 9.76%. Comparing base (7de9630) to head (047b40c).
Report is 19 commits behind head on main.

Files with missing lines Patch % Lines
...trib_drivers/drivers/physik_instrumente/mercury.py 0.00% 53 Missing ⚠️
...odes_contrib_drivers/drivers/RohdeSchwarz/ZVL13.py 0.00% 14 Missing ⚠️
...es_contrib_drivers/drivers/CopperMountain/S5048.py 0.00% 2 Missing ⚠️
...des_contrib_drivers/drivers/Lakeshore/Model_625.py 0.00% 1 Missing ⚠️
.../qcodes_contrib_drivers/drivers/M2/M2_Solstis_3.py 0.00% 1 Missing ⚠️
...qcodes_contrib_drivers/drivers/Minicircuits/ZTM.py 0.00% 1 Missing ⚠️
...rivers/QphoX/CryoSwitchController/qcodes_driver.py 0.00% 1 Missing ⚠️
...s_contrib_drivers/drivers/RohdeSchwarz/FSV_3013.py 0.00% 1 Missing ⚠️
...es_contrib_drivers/drivers/RohdeSchwarz/HMP2020.py 0.00% 1 Missing ⚠️
...es_contrib_drivers/drivers/RohdeSchwarz/HMP2030.py 0.00% 1 Missing ⚠️
... and 7 more
Additional details and impacted files
@@          Coverage Diff          @@
##            main    #419   +/-   ##
=====================================
  Coverage   9.76%   9.76%           
=====================================
  Files        144     144           
  Lines      19744   19744           
=====================================
  Hits        1928    1928           
  Misses     17816   17816           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jenshnielsen jenshnielsen added this pull request to the merge queue Mar 14, 2025
Merged via the queue into QCoDeS:main with commit 7ba331c Mar 14, 2025
9 of 10 checks passed
@jenshnielsen jenshnielsen deleted the jenshnielsen/add_precommit branch March 21, 2025 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants