Suggestion for update (bootstrapping app)#8
Open
tlambert03 wants to merge 2 commits intoQI2lab:mainfrom
Open
Conversation
Author
|
(I can't really test this locally here, since the tests don't seem to be set up to run without hardware right?... so you'll have to verify that its working, and let me know if you have questions) |
Author
|
also, I updated the |
Contributor
|
Hi @tlambert03 ! I just took a look at the state of things. I believe @SJShep is working on and using the stage-engine branch, not main. There, he does execute the |
Contributor
|
And thanks for helping us clean things up! |
Author
|
ok, I can make a PR against that branch instead/as-well 👍 |
Contributor
|
I'm going to work with him to merge to main this week, maybe hold off a day or two? |
Contributor
|
main is now the current state of the control code. |
Author
|
updated! |
Contributor
|
Thanks! We will test later this week and update here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is a suggestion for vendoring a bit less code from pymmcore-gui. I added a public
create_mmguifunction in pymmcore-plus/pymmcore-gui#70 that is designed largely for your use case...This PR removes much of the app bootstrapping logic that was vendored from pymmcore-gui, and leaves only your customizations. In a follow up PR, I will try to show you how to use pymmcore-plus/pymmcore-gui#71 to better contribute custom widgets. (I'll also try to document all this soon)
One important note here: I noticed you commented out the
_install_excepthook()part, and this PR will effectively reinstall it (it happens in thecreate_mmguifunction). I would like to better understand why you originally commented that out, since it's a pretty important step that should almost always run.Note also: I'm pinning your
pymmcore-guidep to the latest commit. Given the rate of development, i would encourage you to manually bump that (probably often) instead of always pulling in the latest main, just in case...