Migrate to Catch2 v3.15.2#6053
Open
prckent wants to merge 7 commits into
Open
Conversation
prckent
marked this pull request as draft
July 24, 2026 17:33
Contributor
Author
|
Test this please |
Contributor
Author
|
Test this please |
Contributor
Author
|
Test this please |
prckent
marked this pull request as ready for review
July 24, 2026 21:50
Contributor
Author
|
Missed a bunch of updates in AFQMC, will fix. |
Contributor
Author
|
Test this please |
1 similar comment
Contributor
Author
|
Test this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
[Initially marked as draft to check CI]Migrate to the latest Catch2 v3.15.2 for testing. https://github.com/catchorg/Catch2
Following the migration guide https://github.com/catchorg/Catch2/blob/devel/docs/migrate-v2-to-v3.md#how-to-migrate-projects-from-v2-to-v3 , this initial PR uses<catch2/catch_all.hpp>. In subsequent PRs we can migrate to more fine grained includes and obtain likely faster compilation times.This PR migrates to the more specialized includes enabled by v3, primarily catch2/catch_test_macros.hpp
Most tests only required updating to use the new header file.
Catch2 v3 is vendored in external_codes/Catch2 and is completely unmodified.
Our previous Catch2 customizations and implementations of ComplexApprox etc. are combined in a single file in src/Utilities/for_testing
Because this PR affects many files, unless there are any major issues I would prefer we merge it and refine subsequently to minimize risk of conflicts with other ongoing work.
This port was largely accomplished with Codex.
What type(s) of changes does this code introduce?
Does this introduce a breaking change?
What systems has this change been tested on?
All unit tests confirmed working with:
gcc16 nompi ubuntu26 dev container
gcc15 nompi macos macports
gcc15 mpi macos macports
Checklist