Write public guide for using BitArray directly #2612
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
One or more of the following people are relevant to this code: |
|
Thanks @SamFerracin , I will leave a review next week. |
abbycross
added a commit
that referenced
this pull request
Feb 3, 2025
ihincks
reviewed
Feb 19, 2025
| @@ -90,14 +90,22 @@ | |||
| "metadata": {}, | |||
There was a problem hiding this comment.
I think this is a nice simplification/clarification in plainer english. I also think that one of the first things that should be said after BitArray is mentioned is that it is just a container for ordered shot data. Then, in the next paragraph, it can be emphasized, somehow, that get_counts is a convenience to change formats.
Reply via ReviewNB
abbycross
reviewed
Mar 24, 2025
abbycross
reviewed
Mar 24, 2025
abbycross
reviewed
Mar 24, 2025
abbycross
reviewed
Mar 24, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 17, 2025
Closes #2650 The improvements made by #2612 I think will also help a lot with the feedback we've been getting about confusion around the `PrimitiveResult` data structure. --------- Co-authored-by: abbycross <[email protected]>
…nto sampler-out
ihincks
approved these changes
May 28, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 3, 2025
CC: @SamFerracin --------- Co-authored-by: christopherporter1 <[email protected]> Co-authored-by: Frank Harkins <[email protected]> Co-authored-by: Samuele Ferracin <[email protected]>
|
Work was finished in #3219 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the guide about inputs and outputs of primitives to show how to make the best use of
BitArrayobjects