Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add networkx requirement #2643

Merged
merged 1 commit into from
Feb 24, 2025
Merged

Add networkx requirement #2643

merged 1 commit into from
Feb 24, 2025

Conversation

frankharkins
Copy link
Member

Parital fix for #2638.

We've resisted adding this requirement for a while, but docs/guides/q-ctrl-optimization-solver.ipynb uses some features of networkx that rustworkx doesn't have (e.g. random_regular_graph). It's possible there are suitable replacements, but I don't know enough about the domain or graph theory to work that out. I think this is the best solution for now.

@Eric-Arellano
Copy link
Collaborator

This is good to go once #2661 is merged.

@mtreinish
Copy link
Member

Fwiw, it would be good if there were open issues for the functionality that rustworkx is missing so we can prioritize adding it. Not just for the tutorials but to make it more useful library.

@frankharkins frankharkins added this pull request to the merge queue Feb 24, 2025
Merged via the queue into main with commit 14e9dc0 Feb 24, 2025
3 checks passed
@frankharkins frankharkins deleted the FH/q-ctrl-rustworkx branch February 24, 2025 15:53
@frankharkins
Copy link
Member Author

I've opened Qiskit/rustworkx#1391, the other feature was the kamada_kawai_layout which already has an open issue, although I don't think that's essential anyway.

On closer inspection of the notebook, it looks like the function specifically wants output of Networkx's readwrite.json_graph.adjacency_data. I think Rustworkx's node_link_json might do the same thing, but we could risk breaking things if the function is somehow tightly coupled to the Networkx output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants