Remove use of deprecated features in transpiler passes #2351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kt474
commented
Jul 30, 2025
| 'All blocks must have time units of "dt". ' | ||
| "Please run TimeUnitConversion pass prior to padding." | ||
| ) | ||
|
|
There was a problem hiding this comment.
Is there an alternative? Or do we just remove the unit property
There was a problem hiding this comment.
There are a couple of alternatives, I think that the key here is making sure that the pass functionality isn't affected by our change... to an extend I guess unit tests should cover this but we should probably reach out to the original authors too to double check.
|
I've labeled this PR as on hold until qiskit offers a good alternative for the duration and unit properties. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Mentioned in slack - some of our transpiler passes use features that were deprecated in Qiskit 1.3.
Details and comments
Fixes #2350