-
Notifications
You must be signed in to change notification settings - Fork 186
Update instance selection behavior #2375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@ElePT Now that the warning message wording is more or less finalized, I think this is ready for a review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Account intialization by token looks good. Let's have an offline discussion regarding instance selection filters before moving forward with the other changes.
Updated the PR description so all warning messages are up to date. The behavior has changed that so when no instance is given and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!! I think that this PR is in a really good state, I just have a couple of minor grammatical suggestions. I played around with different account saving/loading strategies and things seem to work as expected, and the warnings are very informative.
Co-authored-by: Elena Peña Tapia <[email protected]>
Co-authored-by: Elena Peña Tapia <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary
When no instance is specified:
QiskitRuntimeService()
Warning:
Instance was not set at service instantiation. Free and trial plan instances will be prioritized. Based on the following filters, (tags: None, region: us-east, eu-de) and available plans: (premium, internal), the available account instances are: services-internal-eu, services-premium-eu, services-internal-us, services-premium-us. If you need a specific instance set it explicitly either by using a saved account with a saved default instance or passing it in directly to QiskitRuntimeService().
Filtering by
region
andplans_preference
:Warning:
Instance was not set at service instantiation. Based on the following filters, (tags: None, region: us-east, plans_preference: internal), the available account instances are: services-internal-us. If you need a specific instance set it explicitly either by using a saved account with a saved default instance or passing it in directly to QiskitRuntimeService()
if
plans_preference
is given, it will be added to list of filters in the warning message. Ifplans_preference
is not given, the available plans will be listed instead.Retrieving backends:
Warning:
Loading instance: services-internal-eu, plan: internal
Using saved account vs. new account
If using saved account:
Loading default saved account
orLoading saved account: quantum-internal
If token is passed in:
Loading account with the given token. A saved account will not be used.
Details and comments
Fixes #2374
Fixes #2346