Allow passing in and returning the quantum register when loading cirq.Circuits into squin #313
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking into this I realized that the only thing that makes sense (IMO) to pass into or return from a circuit is the list of qubits. I added two simple keyword arguments to control the behavior.
The result is that you can compose kernels that you can easily compose kernels that you generate from circuits. For example:
Here,
get_entangled_qubits
allocates a new register, entangles it and returns the result, whereasentangle_qubits
accepts a register of two qubits to entangle. Of course, you could also pass in and return from the same kernel by setting bothreturn_register=True
andregister_as_argument=True
.FYI, @jon-wurtz , let me know if this covers the use case you had in mind.
Closes #302