-
Notifications
You must be signed in to change notification settings - Fork 1
implement translation of squin qubit loss to stim dialect #322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
should implement a specialized stmt, not rewrite to TrivialError. The TrivialError is just a placeholder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not familiar enough with the code to confidently approve but the loss definitions look good.
op.stmts.X: gate.X, | ||
op.stmts.Y: gate.Y, | ||
op.stmts.Z: gate.Z, | ||
op.stmts.H: gate.H, | ||
op.stmts.S: gate.S, | ||
op.stmts.Identity: gate.Identity, | ||
op.stmts.Reset: collapse.RZ, | ||
squin_noise.stmts.QubitLoss: stim_noise.QubitLoss, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the plan to list all of the squin noise ops here as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, the plan is to rewrite all squin gates and noise channels to cliffords (if not possible error.), and then we will have a program that contain only subset of squin stmts. We then run this rewrite
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright. To be precise, noise and loss are not Clifford. Do you mean include DEPOLARIZING_CHANNEL1 and DEPOLARIZING_CHANNEL2 (randomly selected Pauli errors) as well as LOSS in this list?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes that's what I was thinking
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just talked with @kaihsin on this today, I'm going to spin off the requirements here into a separate issue so that this PR can be merged so the qubit loss statement generating functionality can be immediately available.
Translate the squin qubit loss statement into special stim form.
The necessity of this was brought to my attention by @ChenZhao44