Skip to content

Allow nsite analysis to work with invoke #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

johnzl-777
Copy link
Contributor

@johnzl-777 johnzl-777 commented Jun 20, 2025

Added a test that pretty much mirrors the MWE @weinbe58 showed in #324 , incorporating the fix that @david-pl was working on (:

I also took the liberty to simplify a lot of old tests a bit using the kernel decorator (which either didn't exist when I made the tests OR I wasn't aware of it until after the tests were made 😅 )

@johnzl-777 johnzl-777 linked an issue Jun 20, 2025 that may be closed by this pull request
Copy link

codecov bot commented Jun 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@johnzl-777 johnzl-777 requested a review from weinbe58 June 20, 2025 15:51
Copy link
Contributor

github-actions bot commented Jun 20, 2025

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
8799 7758 88% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
src/bloqade/squin/analysis/nsites/impls.py 94% 🟢
TOTAL 94% 🟢

updated for commit: 102df20 by action🐍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in NSitesAnalysis with the stdlib functions.
1 participant