-
Notifications
You must be signed in to change notification settings - Fork 1
Subgrid shift #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+301
−0
Merged
Subgrid shift #33
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
4e4cbde
add test cases for sub grid shift
WanHsuanLin 0c97a99
add test in test_concrete
WanHsuanLin 485d32c
add implementation for shift_subgrid_x and shift_subgrid_y
WanHsuanLin 80da173
add test for shift_sub_grid_x/y with slice
WanHsuanLin c7dc0f7
add implementation for shift_sub_grid_x/y with slice
WanHsuanLin 52dab28
fix format
WanHsuanLin 141cb9a
Apply suggestion from @Copilot
weinbe58 e5adcf6
Apply suggestion from @Copilot
weinbe58 aa9de2b
Apply suggestion from @Copilot
weinbe58 94934fc
fix format
WanHsuanLin e2167c1
Merge branch 'subgrid_shift' of github.com:WanHsuanLin/bloqade-geomet…
WanHsuanLin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is a user input we should make this an exception instead of an assertion. Generally Assertions are used to enforce internal logic inside a code to catch potential bugs while exceptions are indicating invalid inputs from a user.